Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error when a file size is too large for GRNsight to handle #766

Closed
mihirsamdarshi opened this issue Jun 5, 2019 · 6 comments
Closed

Comments

@mihirsamdarshi
Copy link
Collaborator

Related to issue #747. Currently, there is a limit to the size of the workbook that maybe uploaded, although I am unsure of the capability as it differs between the remote server and local server. We should determine the limit, and return an error if a file exceeds the maximum size, as well as warn the user of the max size in the import menu.

@kdahlquist
Copy link
Collaborator

I'm going to close #747 because we have this one. The file that crashed the server in that issue was 5MB.

@mihirsamdarshi
Copy link
Collaborator Author

mihirsamdarshi commented Jun 6, 2019

A fix is pushed to my branch. I chose an arbitrary file size of 2 MB.

@kdahlquist
Copy link
Collaborator

Do you know what the actual limit is? Obviously 5MB is too big. Just wondering.

@mihirsamdarshi
Copy link
Collaborator Author

I have no clue, 2 MB seems to be far above the upper limit for any of the files that we currently have in the testing suite and the demo files

mihirsamdarshi added a commit that referenced this issue Jun 6, 2019
@kdahlquist
Copy link
Collaborator

I think that at some point, we need to empirically test this, i.e., try uploading larger and larger files and see when it crashes. Doing it at a time when someone is available to restart the server would be preferable. We can't just assume that because our test suite files are of a certain size, that is the size we need. Bear in mind that we allow 74 nodes and 99 edges as our largest graph, so we need to at least be able to accommodate that. People might have more than 3 timepoints of expression data, too.

@kdahlquist
Copy link
Collaborator

I've verified that the error message appears and works. I will close this one and open another issue with a lower priority to check on file sizes on a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants