Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Beta v3.1.21 #771

Merged
merged 14 commits into from
Jun 6, 2019
Merged

Fixes for Beta v3.1.21 #771

merged 14 commits into from
Jun 6, 2019

Conversation

mihirsamdarshi
Copy link
Collaborator

@mihirsamdarshi mihirsamdarshi commented Jun 6, 2019

This PR includes fixes for:
#758
#766
#768
#769

@mihirsamdarshi mihirsamdarshi changed the base branch from master to beta June 6, 2019 21:02
@mihirsamdarshi
Copy link
Collaborator Author

mihirsamdarshi commented Jun 6, 2019

Pull Request Checklist

  • Travis C.I. build passes
  • All four Demos look as expected when loaded
  • Reload works as expected
  • Loading file with Error brings up error modal, and it looks as expected
  • Loading file with Warning brings up warnings modal
  • Import works for both SIF and GraphML
  • Graph can be exported to SIF and GraphML
  • Print works as expected
  • Restrict graph to viewport works as expected (check/uncheck)
  • Viewport Size Changing works as expected (small/medium/large/fit)
  • Toggle between Grid Layout and Force Graph Layout works as expected
  • Force Graph Parameter Sliders change the number above them and have an effect on the graph
  • Locking/Unlocking/Resetting/Undo Resetting the force graph parameters works as expected
  • Enabling and disabling node coloring works as expected
  • Node coloring options work as expected (selection top/bottom dataset, averaging values, changing max value)
  • Weighted graph loaded with the "default to black edges" option checked appears as expected
  • Hide/Show Weights works as expected (always/never/upon mouseover)
  • Edge Weight Normalization Factor can be changed (set/reset)
  • Gray Edge Threshold can be changed, slider changes the number and has an effect on the graph
  • Checking Show Gray Edges as Dashed works as expected (check/uncheck)
  • D-pad left/right/top/bottom/center works as expected
  • Zoom slider changes number and has effect on graph (viewport and menu)
  • Right click on a node opens gene page, page is populated with correct data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant