Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for EFCore.Tasks #33136

Open
AndriySvyryd opened this issue Feb 22, 2024 · 0 comments
Open

Add tests for EFCore.Tasks #33136

AndriySvyryd opened this issue Feb 22, 2024 · 0 comments

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Feb 22, 2024

These tests would need to do the following:

  1. Set up one or more target projects
    a. The task binaries and content files need to be explicitly laid out and referenced, since there is no NuGet package yet when the tests run
  2. Run a dotnet command on one of the above
  3. Assert on the command output and the artifacts of the target project

Features to test:

  1. MsBuild integration for compiled model and precompiled query generation for Build and Publish
  2. NativeAOT
  3. Trimming
  4. Feature flags

Related to #32616
Also see https://github.com/dotnet/efcore/blob/main/eng/testing/linker/trimmingTests.targets

AndriySvyryd added a commit that referenced this issue Feb 24, 2024
Also add a way to manually reference the compiled model before it's generated

Tests tracked by #33136

Fixes #24893
AndriySvyryd added a commit that referenced this issue Mar 4, 2024
Also add a way to manually reference the compiled model before it's generated

Tests tracked by #33136

Fixes #24893
@ajcvickers ajcvickers added this to the 9.0.0 milestone Mar 6, 2024
AndriySvyryd added a commit that referenced this issue Mar 14, 2024
Also add a way to manually reference the compiled model before it's generated

Tests tracked by #33136

Fixes #24893
AndriySvyryd added a commit that referenced this issue Mar 14, 2024
Also add a way to manually reference the compiled model before it's generated

Tests tracked by #33136

Fixes #24893
@AndriySvyryd AndriySvyryd self-assigned this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants