Remove lap feature and all references. #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmitterdorfer
requested changes
Aug 9, 2019
There was a problem hiding this comment.
Nice change! I left a few comments but nothing substantial. Apart from that it's already looking pretty good. I found an additional leftover in
Line 40 in fe1ff28
When raising a PR we should also always set labels and the corresponding milestone. Can you please also do that here (and in future PRs when raising them)?
danielmitterdorfer
added
:Load Driver
danielmitterdorfer
requested changes
Aug 12, 2019
There was a problem hiding this comment.
I have a few asks about the docs but the rest of this change looks fine. I've also applied more labels now. For future reference: We require the following labels on all PRs:
- Type of change, see the release notes script for details
- Indication whether this is a breaking change
- One or more area labels (these start with a colon)
docs/migrate.rst
Outdated
| @@ -10,18 +10,15 @@ This means that on disk, a given race will be found at ``benchmarks/races/62d1e9 | |||
|
|
|||
| Laps feature removed | |||
| ^^^^^^^^^^^^^^^^^^^^ | |||
| The --laps parameter and corresponding multi-run trial functionality has been removed from execution and reporting. | |||
| If you need lap functionality, the following shell script can be used instead: | |||
| The ```--laps``` parameter and corresponding multi-run trial functionality has been removed from execution and reporting. | |||
There was a problem hiding this comment.
This needs to be enclosed in double-backticks, not triple-backticks.
danielmitterdorfer
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature complicates development and can be done with user tags, so is unnecessary.