Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lap feature and all references. #739

Merged
merged 11 commits into from
Aug 14, 2019
Merged

Remove lap feature and all references. #739

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6e24008
Remove lap feature and all references.
Aug 7, 2019
bc4147b
Remove references to LapCounter.
Aug 8, 2019
ccddba7
More lingering lap references.
Aug 8, 2019
bdfe017
Remove unused LAP_SCORE.
Aug 9, 2019
713a0a1
Use sum for consistency.
Aug 9, 2019
238f416
Remove unused write_header parameter.
Aug 9, 2019
4712d49
add_final_results -> add_results
Aug 9, 2019
5ec6740
Remove doc for unused lap metric.
Aug 9, 2019
01ee290
Add lap script example in migration notes.
Aug 9, 2019
d9f19f8
Fix code block and parameter in migration guide.
Aug 12, 2019
eda22e4
Fix triple backtick to double backtick
Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions docs/migrate.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,15 @@ This means that on disk, a given race will be found at ``benchmarks/races/62d1e9

Laps feature removed
^^^^^^^^^^^^^^^^^^^^
The --laps parameter and corresponding multi-run trial functionality has been removed from execution and reporting.
If you need lap functionality, the following shell script can be used instead:
The ```--laps``` parameter and corresponding multi-run trial functionality has been removed from execution and reporting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be enclosed in double-backticks, not triple-backticks.

If you need lap functionality, the following shell script can be used instead::

```bash
RALLY_LAPS=3
RALLY_LAPS=3

for lap in $(seq 1 ${RALLY_LAPS})
do
esrally --pipeline=benchmark-only --user-tag lap:$lap
done

```
for lap in $(seq 1 ${RALLY_LAPS})
do
esrally --pipeline=benchmark-only --user-tag lap:$lap
done


Migrating to Rally 1.2.1
Expand Down