Skip to content

Commit

Permalink
fix(nsis): Cloning packager.config to prevent override
Browse files Browse the repository at this point in the history
This will fix the last issue of #1340 when targets artifact's names are changed.

Close #1340
  • Loading branch information
kossolax authored and develar committed Jun 6, 2017
1 parent 39ae0a4 commit 5b8abcb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/electron-builder/src/targets/nsis.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export class NsisTarget extends Target {

this.packageHelper.refCount++

let options = this.packager.config.nsis || Object.create(null)
let options = Object.assign({}, this.packager.config.nsis) || Object.create(null)
if (targetName !== "nsis") {
options = Object.assign(options, (<any>this.packager.config)[targetName === "nsis-web" ? "nsisWeb" : targetName])
}
Expand Down Expand Up @@ -579,4 +579,4 @@ function computeCustomMessageTranslations(messages: any): Array<string> {

function createMacro(name: string, lines: Array<string>) {
return `\n!macro ${name}\n ${lines.join("\n ")}\n!macroend\n`
}
}

0 comments on commit 5b8abcb

Please sign in to comment.