-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nsis - portable & installer #1340
Comments
Specify custom
But.... damn. You cannot due to config verification :( |
same here:
|
#1340 (comment) working again in the 15.3.0+ |
I think you fixed the artifact name, but I still can't build. Here is package.json:
and error output:
So both portable and nsis run in parallel, both trying to create temporary file, at the same time xxx-yyy-x64.nsis.7z. Thanks for your care |
I forgot to mention that's I've tested using electron-builder 15.4.1 version. |
@kossolax Fixed in 15.4.2. Test added. |
I've updated to 15.4.2, but building still fail. I suppose your previous patch fix when you don't set a artifactName at all. Sorry to insist, but it's look like we don't understand each others. If I build only a portable version it works. If I build only a nsis installer version it works. If I build both at the same time by setting "target": ["nsis", "portable"]" it still doesn't work.
I'm pretty sure it's because both process run in parallel, and both trying to build the archive with the same temporary name "designer-0.5.1-x64.nsis.7z". Please note the "temporary name" is not the same as the final artifact name. "DesignerInstaller.0.5.1.exe" I hope this clarify issue. |
Hello, You could change this line into something like...
So both will create differents temp ".nsis.7z" file. Sadly, this throw another error while converting the .nsis.7z file into a .exe files. The target .exe file is only 150 Ko, and .nsis.7z disapeard. electron-builder@16.5.1
|
Hello again, Thanks for your update. When I'm building, I've only one artifact build, but the error is gone. Here is my package.json
I was watching file creation process:
You can notice the output file at line 238 and 274 from log. err.txt |
Hello, I've just tested with the 17.0.2 version, same issue. @hovancik have you got the same issue ? |
For the record, I also have the same behavior. I have to build nsis and portable separately in order to have both. |
Hello again, Otherwise the compilation produce correctly the 2 outputs. But it doesn't with that's kind of config:
I hope this help. |
When you are building both portable and installer, building fails. I'm using electron-builder@14.5.3
Exception: The process cannot access the file because it is being used by another process.
package.json:
I suppose both output have the same artifactName and the same temporary file name (.nsis.7z), Can we also have a new file macro depending on installer-portable version we are building?
${productName}${buildTarget}.${version}.${ext}
Thanks
The text was updated successfully, but these errors were encountered: