Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent LogBox from crashing on long messages (#38005) #41989

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Prevent LogBox from crashing on long messages (#38005) #41989

merged 3 commits into from
Dec 19, 2023

Conversation

fortmarek
Copy link
Contributor

@fortmarek fortmarek commented Dec 19, 2023 •
edited
Loading

Summary:

Cherry pick of: #38005

Going through a PR due to merge conflicts.

Changelog:

[GENERAL][FIXED] Prevent LogBox from crashing on very long messages

Test Plan:

@motiz88 @fortmarek
Prevent LogBox from crashing on long messages (#38005)
b0291de 
Summary:
Pull Request resolved: #38005

Fixes #32093 by guarding the expensive `BABEL_CODE_FRAME_ERROR_FORMAT` regex with a cheaper initial scan. (Longer term, we should reduce our reliance on string parsing and propagate more structured errors.)

Changelog: [General][Fixed] Prevent LogBox from crashing on very long messages

Reviewed By: GijsWeterings

Differential Revision: D46892454

fbshipit-source-id: 3afadcdd75969c2589bbb06f47d1c4c1c2690abd
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Shopify Partner: Shopify Partner labels Dec 19, 2023
@analysis-bot
Copy link

analysis-bot commented Dec 19, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,492,703 -8,032,431
android hermes armeabi-v7a 7810696 n/a
android hermes x86 8962699 n/a
android hermes x86_64 8824119 n/a
android jsc arm64-v8a 9,151,439 -10,748,510
android jsc armeabi-v7a 8341136 n/a
android jsc x86 9204613 n/a
android jsc x86_64 9463438 n/a

Base commit: 1045b22
Branch: main

@fortmarek fortmarek merged commit c3c6cf4 into 0.72-stable Dec 19, 2023
64 checks passed
@fortmarek fortmarek deleted the fortmarek/prevent-log-box branch December 19, 2023 13:55
This was referenced Dec 27, 2023
Merged
Merged
This was referenced Jan 4, 2024
Merged
Merged
Merged
Closed
This was referenced Feb 28, 2024
Merged
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Shopify Partner: Shopify Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fortmarek @analysis-bot @cipolleschi @facebook-github-bot @motiz88