Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload source distribution to PyPi #590

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Conversation

AbdBarho
Copy link
Contributor

What does this PR do?

Upload source distribution to PyPi. Continuation of #588

I am unsure if this is strictly necessary since we basically upload wheels for every supported platform, but it won't hurt ¯\_(ツ)_/¯

Related #533

I have considered consoldating the env from the last 2 steps to the global env, but I don't want any steps (especially external actions) to access the token.

Example sdist:
https://test.pypi.org/project/formers/0.0.16rc379/#files

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 14, 2022
@danthe3rd
Copy link
Contributor

This looks great - thanks a lot! Is it ready to merge?
Btw, we are limited to 10GB of storage on pypi. One version takes ~300MB, so we can "afford" ~30 versions.
I suggest we keep the last ~10 RC, and last ~20 tagged versions - I'm working on a script to automate the cleaning of the previous RC.

@AbdBarho
Copy link
Contributor Author

AbdBarho commented Dec 14, 2022

it is ready to merge!

The answer to your suggestion depends entirely on how often do you plan on releasing new versions. My biggest concern is old versions of the library not being available anymore.

~20 tagged versions + release once a month = ~1.5 years average lifetime of a version, which doesn't sound like much.

Maybe after 1.5 years the project is big enough to request another storage increase from pypi :p

This is totally up to you and maybe others on the team to decide, I don't really mind either way.

@danthe3rd
Copy link
Contributor

Yeah, our versions will also quickly be outdated, as they rely on a specific PyTorch version. We could keep the source distribution tho for tagged releases

@danthe3rd danthe3rd merged commit e117abd into facebookresearch:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants