Publish to PyPi on Git Tag #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
danthe3rd
approved these changes
Dec 15, 2022
.github/workflows/wheels.yml
Outdated
| @@ -4,6 +4,8 @@ on: | |||
| push: | |||
| branches: | |||
| - main | |||
| tags: | |||
| - "*" | |||
There was a problem hiding this comment.
Can we have a sort of regexp here to ensure we only match tags that look like a version number?
There was a problem hiding this comment.
Assuming semantic versioning, so something like [0-9]+.[0-9]+.[0-9]+
With or without v at the beginning? I might have to check again if pypi accepts versions prefixed with v.
Edit: it does not
There was a problem hiding this comment.
We don't need the "v" prefix
|
I'll merge once the CPU tests pass :) |
|
Awesome! Thanks a lot - a lot of users will be thankful that we finally can have binary wheels - and also with windows supported :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final piece in the pip trilogy #533.
Continuation of #588 and #590.
This should hopefully be all the work needed to have pip wheels always up-to-date.
I added a check to see if the version in
version.txtmatches the git tag, not sure if necessary, maybe it is okay if they are different?After this, I intend to do a clean up of the workflow code since it is starting to get a bit messy, especially with all the os specific stuff.
Also, there was a mention of having scripts that cleans up old releases from PyPi, @danthe3rd ping me if needed.