Update/ad-reporting-v2 #15
Conversation
There was a problem hiding this comment.
@fivetran-sheringuyen thanks so much for putting this PR together! Your updates look mostly good, I just had a few comments inline that should be addressed before we are good to go.
- A few minor README and CHANGELOG updates.
- A question about including the
match_typefield to the keyword report - Question around filtering the url report.
- Addressing any other inline comments I have from this review.
I also did take a closer look at the url report and the logic you applied makes sense to me! I really appreciated your addition to the DECISIONLOG about the auto tagging nature within Microsoft Ads.
| @@ -1,3 +1,16 @@ | |||
| # dbt_microsoft_ads v0.5.0 | |||
There was a problem hiding this comment.
Can you add the PR link to the CHANGELOG
packages.yml
Outdated
| # - package: fivetran/microsoft_ads_source | ||
| # version: [">=0.4.0", "<0.5.0"] | ||
| - git: https://github.com/fivetran/dbt_microsoft_ads_source.git | ||
| revision: update/ad-reporting-v2 | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Reminder to switch before merge.
README.md
Outdated
| # 📣 What does this dbt package do? | ||
| - Produces modeled tables that leverage Microsoft Ads data from [Fivetran's connector](https://fivetran.com/docs/applications/microsoft-advertising) in the format described by [this ERD](https://fivetran.com/docs/applications/microsoft-advertising#schemainformation) and builds off the output of our [Microsoft Ads source package](https://github.com/fivetran/dbt_microsoft_ads_source). | ||
| - Enables you to better understand the performance of your ads across varying grains: | ||
| - Providing an account, campaign, ad group, keyword, ad, and utm level reports. |
There was a problem hiding this comment.
Do you feel it is relevant to also include the search term report in this list?
README.md
Outdated
| | [microsoft_ads__ad_group_report](https://fivetran.github.io/dbt_microsoft_ads/#!/model/model.microsoft_ads.microsoft_ads__ad_group_report) | Each record in this table represents the daily performance at the ad group level. | | ||
| | [microsoft_ads__ad_report](https://fivetran.github.io/dbt_microsoft_ads/#!/model/model.microsoft_ads.microsoft_ads__ad_report) | Each record in this table represents the daily performance at the ad level. | | ||
| | [microsoft_ads__keyword_report](https://fivetran.github.io/dbt_microsoft_ads/#!/model/model.microsoft_ads.microsoft_ads__keyword_report) | Each record in this table represents the daily performance at the ad group level for keywords. | | ||
| | [microsoft_ads__search_report](https://fivetran.github.io/dbt_microsoft_ads/#!/model/model.microsoft_ads.microsoft_ads__ad_report) | Each record in this table represents the daily performance at the search level. | |
There was a problem hiding this comment.
It looks like this link is pointing to the ad report instead of the search report.
|
Hey @fivetran-joemarkiewicz, just updated the PR with your suggested fixes. Let me know if you have any other questions! |
There was a problem hiding this comment.
Thanks for making the updates @fivetran-sheringuyen! These look good to go on my end 😄
Pull Request
Are you a current Fivetran customer?
Fivetran Employee
What change(s) does this PR introduce?
🚨 Breaking Changes 🚨
microsoft_ads__ad_adapterreport has been renamed tomicrosoft_ads__url_reportto more accurately reflect contents of report.🎉 Feature Enhancements 🎉
microsoft_ads__ad_reportmicrosoft_ads__keyword_reportmicrosoft_ads__search_reportREADMEupdates for easier navigation and use of the package.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
😌
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.