Suppress warnings #946

okkez · 2016-05-12T03:17:41Z

In previous version about 2500 lines of warnings.
In this version about 1200 lines of warnings.

Remained warinigs:

From ServerEngine about 400 lines
- See Suppress Ruby warnings treasure-data/serverengine#47
Encoding.default_external, Encoding.default_internal about 800 lines
Some other warnings about 50 lines

This change suppresses following warnings: test/plugin/test_in_forward.rb:62: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:77: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:92: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:107: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:111: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:130: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:147: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:163: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:183: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:200: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:216: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:221: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:239: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:366: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:393: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:420: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:446: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:470: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:492: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:515: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:537: warning: shadowing outer local variable - time

This change suppresses following warnings: lib/fluent/plugin_helper.rb:35: warning: `*' interpreted as argument prefix Rubocop says: > Ambiguous splat operator. Parenthesize the method arguments if it's > surely a splat operator, or add a whitespace to the right of the * if it > should be a multiplication.

This change suppresses following warning: lib/fluent/plugin/buffer/file_chunk.rb:174: warning: assigned but unused variable - pos

tagomoris · 2016-05-12T10:43:22Z

lib/fluent/plugin/output.rb

@@ -561,8 +561,8 @@ def handle_stream_with_standard_format(tag, es)
          meta_and_data[meta].add(time, record)
          records += 1
        end
-        meta_and_data.each_pair do |meta, es|


Please remove these changes about meta_and_data: I'm fixing these on other branches.

This change suppresses following warnings: test/plugin/test_buffer.rb:237: warning: assigned but unused variable - m test/plugin/test_buffer.rb:245: warning: assigned but unused variable - mx

This change suppresses following warning: test/plugin/test_buffer.rb:573: warning: assigned but unused variable - prev_stage_size

This change suppresses following warnings: test/plugin/test_buffer_file_chunk.rb:333: warning: assigned but unused variable - created_at test/plugin/test_buffer_file_chunk.rb:334: warning: assigned but unused variable - modified_at test/plugin/test_buffer_file_chunk.rb:457: warning: assigned but unused variable - created_at test/plugin/test_buffer_file_chunk.rb:458: warning: assigned but unused variable - modified_at

This change suppresses following warnings: test/plugin/test_filter.rb:221: warning: assigned but unused variable - data test/plugin/test_filter.rb:222: warning: assigned but unused variable - dummy_error

This change suppresses following warning: lib/fluent/plugin/in_forward.rb:232: warning: assigned but unused variable - proto

This change suppresses following warnings: lib/fluent/plugin/in_forward.rb:245: warning: assigned but unused variable - e

Because we use `child_uri` below the here (in comment). This change suppresses following warning: lib/fluent/process.rb:119: warning: assigned but unused variable - child_uri

This change suppresses following warnings: test/plugin/test_output.rb:92: warning: `*' interpreted as argument prefix

This change suppresses following warnings: test/plugin/test_output_as_buffered.rb:87: warning: `*' interpreted as argument prefix

This change suppresses following warnings: test/plugin/test_output_as_buffered.rb:255: warning: assigned but unused variable - event_size test/plugin/test_output_as_buffered.rb:362: warning: assigned but unused variable - event_size

This change suppresses following warnings: test/plugin/test_output_as_buffered_retries.rb:70: warning: `*' interpreted as argument prefix

This change suppresses following warnings: test/plugin/test_output_as_buffered_retries.rb:356: warning: assigned but unused variable - first_failure test/plugin/test_output_as_buffered_retries.rb:572: warning: assigned but unused variable - first_failure

This change suppresses following warnings: fluentd/test/plugin/test_output_as_buffered_secondary.rb:70: warning: `*' interpreted as argument prefix

This change suppresses following warnings: test/plugin/test_output_as_standard.rb:53: warning: `*' interpreted as argument prefix

This change suppresses following warnings: test/plugin_helper/test_storage.rb:284: warning: assigned but unused variable - s test/plugin_helper/test_storage.rb:296: warning: assigned but unused variable - s

This change suppresses following warnings: test/plugin_helper/test_thread.rb:80: warning: assigned but unused variable - t1 test/plugin_helper/test_thread.rb:83: warning: assigned but unused variable - t2 test/plugin_helper/test_thread.rb:86: warning: assigned but unused variable - t3

This change suppresses following warnings(about 25 lines) lib/fluent/system_config.rb:106: warning: global variable `$_system_config' not initialized lib/fluent/system_config.rb:109: warning: instance variable @_system_config not initialized lib/fluent/system_config.rb:114: warning: instance variable @_system_config not initialized (snip)

test/plugin/test_out_forward.rb:393: warning: assigned but unused variable - e

This change suppress following warning: lib/fluent/plugin/out_forward.rb:125: warning: shadowing outer local variable - e

This change suppresses following warnings: lib/fluent/plugin/out_forward.rb:443: warning: assigned but unused variable - port lib/fluent/plugin/out_forward.rb:443: warning: assigned but unused variable - host

This change suppresses following warnings(177 lines) lib/fluent/configurable.rb:71: warning: instance variable @log_level not initialized

@meta

This change suppresses following warnings: lib/fluent/plugin/buffer/file_chunk.rb:135: warning: instance variable @meta not initialized lib/fluent/plugin/buffer/file_chunk.rb:135: warning: instance variable @meta not initialized

@i

This change suppresses following warnings: test/plugin/test_output_as_buffered_retries.rb:91: warning: instance variable @i not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized

@i

This change suppresses following warnings: test/plugin/test_output_as_buffered_secondary.rb:83: warning: instance variable @i not initialized test/plugin/test_output_as_buffered_secondary.rb:83: warning: instance variable @i not initialized test/plugin/test_output_as_buffered_secondary.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_secondary.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_secondary.rb:83: warning: instance variable @i not initialized test/plugin/test_output_as_buffered_secondary.rb:83: warning: instance variable @i not initialized

@Format

This change suppresses following warnings (20lines): test/plugin/test_output_as_buffered.rb:38: warning: instance variable @shutdown_hook not initialized test/plugin/test_output_as_buffered.rb:24: warning: instance variable @Format not initialized

This change suppresses following warnings(about 500 lines or more): lib/fluent/plugin/owned_by_mixin.rb:30: warning: instance variable @_owner not initialized lib/fluent/plugin/owned_by_mixin.rb:34: warning: instance variable @log not initialized

@id

This change suppresses following warnings(50 lines): lib/fluent/plugin_id.rb:54: warning: instance variable @id not initialized lib/fluent/plugin_id.rb:50: warning: instance variable @_id_configured not initialized

This change suppresses following warnings: test/config/test_system_config.rb:87: warning: instance variable @file_permission not initialized test/config/test_system_config.rb:88: warning: instance variable @dir_permission not initialized test/config/test_system_config.rb:87: warning: instance variable @file_permission not initialized test/config/test_system_config.rb:88: warning: instance variable @dir_permission not initialized test/config/test_system_config.rb:52: warning: instance variable @file_permission not initialized test/config/test_system_config.rb:53: warning: instance variable @dir_permission not initialized

test/plugin/test_buf_file.rb:681: warning: File.exists? is a deprecated name, use File.exist? instead

This change suppress following warnings(138 lines): test/plugin_helper/test_retry_state.rb:10: warning: method redefined; discarding old current_time test/plugin_helper/test_retry_state.rb:10: warning: previous definition of current_time was here

@loop

This change suppresses following warnings: test/plugin/test_out_forward.rb:451: warning: instance variable @loop not initialized test/plugin/test_out_forward.rb:452: warning: instance variable @thread not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/out_forward.rb:401: warning: instance variable @finished not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized

@Format

This change suppresses following warnings: test/plugin/test_output.rb:52: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output.rb:58: warning: instance variable @Format not initialized test/plugin/test_output.rb:58: warning: instance variable @Format not initialized test/plugin/test_output.rb:58: warning: instance variable @Format not initialized test/plugin/test_output.rb:58: warning: instance variable @Format not initialized test/plugin/test_output.rb:36: warning: instance variable @Format not initialized test/plugin/test_output.rb:36: warning: instance variable @Format not initialized test/plugin/test_output.rb:23: warning: instance variable @Format not initialized test/plugin/test_output.rb:23: warning: instance variable @Format not initialized test/plugin/test_output.rb:49: warning: instance variable @prefer_buffered_processing not initialized

@i

This change suppresses following warnings: test/plugin/test_output_as_standard.rb:69: warning: instance variable @i not initialized

@finished

This change suppresses following warnings: lib/fluent/plugin/out_forward.rb:403: warning: instance variable @finished not initialized

Because in_forward has option `bind` for this purpose.

okkez · 2016-05-13T04:40:19Z

I've pushed commits and rebased for all comments.

tagomoris · 2016-05-13T05:55:25Z

Great!

okkez · 2016-05-13T06:05:22Z

Thanks!

okkez added 3 commits May 11, 2016 10:24

Remove an unused local variable

b05e167

This change suppresses following warning: lib/fluent/plugin/buffer/file_chunk.rb:174: warning: assigned but unused variable - pos

tagomoris reviewed May 12, 2016
View reviewed changes

okkez added 25 commits May 13, 2016 11:48

Add "_" prefix to suppress warnings

966a563

This change suppresses following warnings: test/plugin/test_buffer.rb:237: warning: assigned but unused variable - m test/plugin/test_buffer.rb:245: warning: assigned but unused variable - mx

Remove an unused local variable

2ae10a4

This change suppresses following warning: test/plugin/test_buffer.rb:573: warning: assigned but unused variable - prev_stage_size

Remove unused local variables

4998a24

This change suppresses following warnings: test/plugin/test_filter.rb:221: warning: assigned but unused variable - data test/plugin/test_filter.rb:222: warning: assigned but unused variable - dummy_error

Add "_" prefix to unused local variable

768c1e4

This change suppresses following warning: lib/fluent/plugin/in_forward.rb:232: warning: assigned but unused variable - proto

Remove an unused variable

8f8ac0a

This change suppresses following warnings: lib/fluent/plugin/in_forward.rb:245: warning: assigned but unused variable - e

Comment out unused assignment

06ebb46

Because we use `child_uri` below the here (in comment). This change suppresses following warning: lib/fluent/process.rb:119: warning: assigned but unused variable - child_uri

Fix parentheses

d688345

This change suppresses following warnings: test/plugin/test_output.rb:92: warning: `*' interpreted as argument prefix

Fix parentheses

38f7015

This change suppresses following warnings: test/plugin/test_output_as_buffered.rb:87: warning: `*' interpreted as argument prefix

Remove unused assignments

9c932eb

This change suppresses following warnings: test/plugin/test_output_as_buffered.rb:255: warning: assigned but unused variable - event_size test/plugin/test_output_as_buffered.rb:362: warning: assigned but unused variable - event_size

Fix parentheses

b037e0e

This change suppresses following warnings: test/plugin/test_output_as_buffered_retries.rb:70: warning: `*' interpreted as argument prefix

Fix parentheses

1c7a5d5

This change suppresses following warnings: fluentd/test/plugin/test_output_as_buffered_secondary.rb:70: warning: `*' interpreted as argument prefix

Fix parentheses

1376428

This change suppresses following warnings: test/plugin/test_output_as_standard.rb:53: warning: `*' interpreted as argument prefix

Remove unused local variables

1c95b14

This change suppresses following warnings: test/plugin_helper/test_storage.rb:284: warning: assigned but unused variable - s test/plugin_helper/test_storage.rb:296: warning: assigned but unused variable - s

Remove unused local variable

ba37d2d

test/plugin/test_out_forward.rb:393: warning: assigned but unused variable - e

Use descriptive variable name

589395b

This change suppress following warning: lib/fluent/plugin/out_forward.rb:125: warning: shadowing outer local variable - e

Remove unused local variables

6d71ebf

This change suppresses following warnings: lib/fluent/plugin/out_forward.rb:443: warning: assigned but unused variable - port lib/fluent/plugin/out_forward.rb:443: warning: assigned but unused variable - host

Check instance variable is defined before use it

f722e5e

This change suppresses following warnings(177 lines) lib/fluent/configurable.rb:71: warning: instance variable @log_level not initialized

Initialize uninitialized instance variable

0d21d86

This change suppresses following warnings: lib/fluent/plugin/buffer/file_chunk.rb:135: warning: instance variable @meta not initialized lib/fluent/plugin/buffer/file_chunk.rb:135: warning: instance variable @meta not initialized

okkez force-pushed the suppress-warnings-step3 branch from 7473872 to 3535858 Compare May 13, 2016 02:52

okkez added 10 commits May 13, 2016 12:36

Check instance variable is defined before use it

92a94c4

This change suppresses following warnings(50 lines): lib/fluent/plugin_id.rb:54: warning: instance variable @id not initialized lib/fluent/plugin_id.rb:50: warning: instance variable @_id_configured not initialized

Use File.exist? instead of File.exists?

1f35d95

test/plugin/test_buf_file.rb:681: warning: File.exists? is a deprecated name, use File.exist? instead

Add alias for :current_time

c71066b

This change suppress following warnings(138 lines): test/plugin_helper/test_retry_state.rb:10: warning: method redefined; discarding old current_time test/plugin_helper/test_retry_state.rb:10: warning: previous definition of current_time was here

Initialize Initialize uninitialized instance variables

97d1c9e

This change suppresses following warnings: test/plugin/test_output_as_standard.rb:69: warning: instance variable @i not initialized

Initialize Initialize uninitialized instance variables

5b32595

This change suppresses following warnings: lib/fluent/plugin/out_forward.rb:403: warning: instance variable @finished not initialized

Use @bind instead of @host

8b40e15

Because in_forward has option `bind` for this purpose.

Delegate PluginLogger#reset to @logger properly

0a31ded

okkez force-pushed the suppress-warnings-step3 branch from 3535858 to 0a31ded Compare May 13, 2016 03:36

tagomoris merged commit 6826156 into fluent:master May 13, 2016

okkez deleted the suppress-warnings-step3 branch May 13, 2016 06:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suppress warnings #946

Suppress warnings #946

okkez commented May 12, 2016

tagomoris May 12, 2016 •

edited

Loading

okkez commented May 13, 2016

tagomoris commented May 13, 2016

okkez commented May 13, 2016

Suppress warnings #946

Suppress warnings #946

Conversation

okkez commented May 12, 2016

tagomoris May 12, 2016 • edited Loading

Choose a reason for hiding this comment

okkez commented May 13, 2016

tagomoris commented May 13, 2016

okkez commented May 13, 2016

tagomoris May 12, 2016 •

edited

Loading