-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress warnings #946
Suppress warnings #946
Commits on May 11, 2016
-
Add '_' prefix to block variables
This change suppresses following warnings: test/plugin/test_in_forward.rb:62: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:77: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:92: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:107: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:111: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:130: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:147: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:163: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:183: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:200: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:216: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:221: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:239: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:366: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:393: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:420: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:446: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:470: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:492: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:515: warning: shadowing outer local variable - time test/plugin/test_in_forward.rb:537: warning: shadowing outer local variable - time
Configuration menu - View commit details
-
Copy full SHA for 98c7c8c - Browse repository at this point
Copy the full SHA 98c7c8cView commit details -
This change suppresses following warnings: lib/fluent/plugin_helper.rb:35: warning: `*' interpreted as argument prefix Rubocop says: > Ambiguous splat operator. Parenthesize the method arguments if it's > surely a splat operator, or add a whitespace to the right of the * if it > should be a multiplication.
Configuration menu - View commit details
-
Copy full SHA for c37ffb3 - Browse repository at this point
Copy the full SHA c37ffb3View commit details -
Remove an unused local variable
This change suppresses following warning: lib/fluent/plugin/buffer/file_chunk.rb:174: warning: assigned but unused variable - pos
Configuration menu - View commit details
-
Copy full SHA for b05e167 - Browse repository at this point
Copy the full SHA b05e167View commit details
Commits on May 13, 2016
-
Add "_" prefix to suppress warnings
This change suppresses following warnings: test/plugin/test_buffer.rb:237: warning: assigned but unused variable - m test/plugin/test_buffer.rb:245: warning: assigned but unused variable - mx
Configuration menu - View commit details
-
Copy full SHA for 966a563 - Browse repository at this point
Copy the full SHA 966a563View commit details -
Remove an unused local variable
This change suppresses following warning: test/plugin/test_buffer.rb:573: warning: assigned but unused variable - prev_stage_size
Configuration menu - View commit details
-
Copy full SHA for 2ae10a4 - Browse repository at this point
Copy the full SHA 2ae10a4View commit details -
This change suppresses following warnings: test/plugin/test_buffer_file_chunk.rb:333: warning: assigned but unused variable - created_at test/plugin/test_buffer_file_chunk.rb:334: warning: assigned but unused variable - modified_at test/plugin/test_buffer_file_chunk.rb:457: warning: assigned but unused variable - created_at test/plugin/test_buffer_file_chunk.rb:458: warning: assigned but unused variable - modified_at
Configuration menu - View commit details
-
Copy full SHA for 4c33847 - Browse repository at this point
Copy the full SHA 4c33847View commit details -
This change suppresses following warnings: test/plugin/test_filter.rb:221: warning: assigned but unused variable - data test/plugin/test_filter.rb:222: warning: assigned but unused variable - dummy_error
Configuration menu - View commit details
-
Copy full SHA for 4998a24 - Browse repository at this point
Copy the full SHA 4998a24View commit details -
Add "_" prefix to unused local variable
This change suppresses following warning: lib/fluent/plugin/in_forward.rb:232: warning: assigned but unused variable - proto
Configuration menu - View commit details
-
Copy full SHA for 768c1e4 - Browse repository at this point
Copy the full SHA 768c1e4View commit details -
This change suppresses following warnings: lib/fluent/plugin/in_forward.rb:245: warning: assigned but unused variable - e
Configuration menu - View commit details
-
Copy full SHA for 8f8ac0a - Browse repository at this point
Copy the full SHA 8f8ac0aView commit details -
Because we use `child_uri` below the here (in comment). This change suppresses following warning: lib/fluent/process.rb:119: warning: assigned but unused variable - child_uri
Configuration menu - View commit details
-
Copy full SHA for 06ebb46 - Browse repository at this point
Copy the full SHA 06ebb46View commit details -
This change suppresses following warnings: test/plugin/test_output.rb:92: warning: `*' interpreted as argument prefix
Configuration menu - View commit details
-
Copy full SHA for d688345 - Browse repository at this point
Copy the full SHA d688345View commit details -
This change suppresses following warnings: test/plugin/test_output_as_buffered.rb:87: warning: `*' interpreted as argument prefix
Configuration menu - View commit details
-
Copy full SHA for 38f7015 - Browse repository at this point
Copy the full SHA 38f7015View commit details -
This change suppresses following warnings: test/plugin/test_output_as_buffered.rb:255: warning: assigned but unused variable - event_size test/plugin/test_output_as_buffered.rb:362: warning: assigned but unused variable - event_size
Configuration menu - View commit details
-
Copy full SHA for 9c932eb - Browse repository at this point
Copy the full SHA 9c932ebView commit details -
This change suppresses following warnings: test/plugin/test_output_as_buffered_retries.rb:70: warning: `*' interpreted as argument prefix
Configuration menu - View commit details
-
Copy full SHA for b037e0e - Browse repository at this point
Copy the full SHA b037e0eView commit details -
Add "_" prefix to unused local variables
This change suppresses following warnings: test/plugin/test_output_as_buffered_retries.rb:356: warning: assigned but unused variable - first_failure test/plugin/test_output_as_buffered_retries.rb:572: warning: assigned but unused variable - first_failure
Configuration menu - View commit details
-
Copy full SHA for 49748ad - Browse repository at this point
Copy the full SHA 49748adView commit details -
This change suppresses following warnings: fluentd/test/plugin/test_output_as_buffered_secondary.rb:70: warning: `*' interpreted as argument prefix
Configuration menu - View commit details
-
Copy full SHA for 1c7a5d5 - Browse repository at this point
Copy the full SHA 1c7a5d5View commit details -
This change suppresses following warnings: test/plugin/test_output_as_standard.rb:53: warning: `*' interpreted as argument prefix
Configuration menu - View commit details
-
Copy full SHA for 1376428 - Browse repository at this point
Copy the full SHA 1376428View commit details -
This change suppresses following warnings: test/plugin_helper/test_storage.rb:284: warning: assigned but unused variable - s test/plugin_helper/test_storage.rb:296: warning: assigned but unused variable - s
Configuration menu - View commit details
-
Copy full SHA for 1c95b14 - Browse repository at this point
Copy the full SHA 1c95b14View commit details -
This change suppresses following warnings: test/plugin_helper/test_thread.rb:80: warning: assigned but unused variable - t1 test/plugin_helper/test_thread.rb:83: warning: assigned but unused variable - t2 test/plugin_helper/test_thread.rb:86: warning: assigned but unused variable - t3
Configuration menu - View commit details
-
Copy full SHA for 4fe7496 - Browse repository at this point
Copy the full SHA 4fe7496View commit details -
Use initialized global/instance variables
This change suppresses following warnings(about 25 lines) lib/fluent/system_config.rb:106: warning: global variable `$_system_config' not initialized lib/fluent/system_config.rb:109: warning: instance variable @_system_config not initialized lib/fluent/system_config.rb:114: warning: instance variable @_system_config not initialized (snip)
Configuration menu - View commit details
-
Copy full SHA for 3ea2e03 - Browse repository at this point
Copy the full SHA 3ea2e03View commit details -
test/plugin/test_out_forward.rb:393: warning: assigned but unused variable - e
Configuration menu - View commit details
-
Copy full SHA for ba37d2d - Browse repository at this point
Copy the full SHA ba37d2dView commit details -
This change suppress following warning: lib/fluent/plugin/out_forward.rb:125: warning: shadowing outer local variable - e
Configuration menu - View commit details
-
Copy full SHA for 589395b - Browse repository at this point
Copy the full SHA 589395bView commit details -
This change suppresses following warnings: lib/fluent/plugin/out_forward.rb:443: warning: assigned but unused variable - port lib/fluent/plugin/out_forward.rb:443: warning: assigned but unused variable - host
Configuration menu - View commit details
-
Copy full SHA for 6d71ebf - Browse repository at this point
Copy the full SHA 6d71ebfView commit details -
Check instance variable is defined before use it
This change suppresses following warnings(177 lines) lib/fluent/configurable.rb:71: warning: instance variable @log_level not initialized
Configuration menu - View commit details
-
Copy full SHA for f722e5e - Browse repository at this point
Copy the full SHA f722e5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d21d86 - Browse repository at this point
Copy the full SHA 0d21d86View commit details -
Initialize uninitialized instance variables
This change suppresses following warnings: test/plugin/test_output_as_buffered_retries.rb:91: warning: instance variable @i not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_retries.rb:27: warning: instance variable @prefer_delayed_commit not initialized
Configuration menu - View commit details
-
Copy full SHA for 166999e - Browse repository at this point
Copy the full SHA 166999eView commit details -
Initialize uninitialized instance variables
This change suppresses following warnings: test/plugin/test_output_as_buffered_secondary.rb:83: warning: instance variable @i not initialized test/plugin/test_output_as_buffered_secondary.rb:83: warning: instance variable @i not initialized test/plugin/test_output_as_buffered_secondary.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_secondary.rb:27: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output_as_buffered_secondary.rb:83: warning: instance variable @i not initialized test/plugin/test_output_as_buffered_secondary.rb:83: warning: instance variable @i not initialized
Configuration menu - View commit details
-
Copy full SHA for 6779c8e - Browse repository at this point
Copy the full SHA 6779c8eView commit details -
Initialize uninitialized instance variables
This change suppresses following warnings (20lines): test/plugin/test_output_as_buffered.rb:38: warning: instance variable @shutdown_hook not initialized test/plugin/test_output_as_buffered.rb:24: warning: instance variable @Format not initialized
Configuration menu - View commit details
-
Copy full SHA for 1835e24 - Browse repository at this point
Copy the full SHA 1835e24View commit details -
Check instance variable is defined before use it
This change suppresses following warnings(about 500 lines or more): lib/fluent/plugin/owned_by_mixin.rb:30: warning: instance variable @_owner not initialized lib/fluent/plugin/owned_by_mixin.rb:34: warning: instance variable @log not initialized
Configuration menu - View commit details
-
Copy full SHA for ee4ce43 - Browse repository at this point
Copy the full SHA ee4ce43View commit details -
Check instance variable is defined before use it
This change suppresses following warnings(50 lines): lib/fluent/plugin_id.rb:54: warning: instance variable @id not initialized lib/fluent/plugin_id.rb:50: warning: instance variable @_id_configured not initialized
Configuration menu - View commit details
-
Copy full SHA for 92a94c4 - Browse repository at this point
Copy the full SHA 92a94c4View commit details -
Initialize Initialize uninitialized instance variables
This change suppresses following warnings: test/config/test_system_config.rb:87: warning: instance variable @file_permission not initialized test/config/test_system_config.rb:88: warning: instance variable @dir_permission not initialized test/config/test_system_config.rb:87: warning: instance variable @file_permission not initialized test/config/test_system_config.rb:88: warning: instance variable @dir_permission not initialized test/config/test_system_config.rb:52: warning: instance variable @file_permission not initialized test/config/test_system_config.rb:53: warning: instance variable @dir_permission not initialized
Configuration menu - View commit details
-
Copy full SHA for 02ea7af - Browse repository at this point
Copy the full SHA 02ea7afView commit details -
Use File.exist? instead of File.exists?
test/plugin/test_buf_file.rb:681: warning: File.exists? is a deprecated name, use File.exist? instead
Configuration menu - View commit details
-
Copy full SHA for 1f35d95 - Browse repository at this point
Copy the full SHA 1f35d95View commit details -
This change suppress following warnings(138 lines): test/plugin_helper/test_retry_state.rb:10: warning: method redefined; discarding old current_time test/plugin_helper/test_retry_state.rb:10: warning: previous definition of current_time was here
Configuration menu - View commit details
-
Copy full SHA for c71066b - Browse repository at this point
Copy the full SHA c71066bView commit details -
Initialize Initialize uninitialized instance variables
This change suppresses following warnings: test/plugin/test_out_forward.rb:451: warning: instance variable @loop not initialized test/plugin/test_out_forward.rb:452: warning: instance variable @thread not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/out_forward.rb:401: warning: instance variable @finished not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/in_forward.rb:291: warning: instance variable @source not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized lib/fluent/plugin/socket_util.rb:61: warning: instance variable @timeout not initialized
Configuration menu - View commit details
-
Copy full SHA for 70b70ae - Browse repository at this point
Copy the full SHA 70b70aeView commit details -
Initialize Initialize uninitialized instance variables
This change suppresses following warnings: test/plugin/test_output.rb:52: warning: instance variable @prefer_delayed_commit not initialized test/plugin/test_output.rb:58: warning: instance variable @Format not initialized test/plugin/test_output.rb:58: warning: instance variable @Format not initialized test/plugin/test_output.rb:58: warning: instance variable @Format not initialized test/plugin/test_output.rb:58: warning: instance variable @Format not initialized test/plugin/test_output.rb:36: warning: instance variable @Format not initialized test/plugin/test_output.rb:36: warning: instance variable @Format not initialized test/plugin/test_output.rb:23: warning: instance variable @Format not initialized test/plugin/test_output.rb:23: warning: instance variable @Format not initialized test/plugin/test_output.rb:49: warning: instance variable @prefer_buffered_processing not initialized
Configuration menu - View commit details
-
Copy full SHA for f87c232 - Browse repository at this point
Copy the full SHA f87c232View commit details -
Initialize Initialize uninitialized instance variables
This change suppresses following warnings: test/plugin/test_output_as_standard.rb:69: warning: instance variable @i not initialized
Configuration menu - View commit details
-
Copy full SHA for 97d1c9e - Browse repository at this point
Copy the full SHA 97d1c9eView commit details -
Initialize Initialize uninitialized instance variables
This change suppresses following warnings: lib/fluent/plugin/out_forward.rb:403: warning: instance variable @finished not initialized
Configuration menu - View commit details
-
Copy full SHA for 5b32595 - Browse repository at this point
Copy the full SHA 5b32595View commit details -
Because in_forward has option `bind` for this purpose.
Configuration menu - View commit details
-
Copy full SHA for 8b40e15 - Browse repository at this point
Copy the full SHA 8b40e15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a31ded - Browse repository at this point
Copy the full SHA 0a31dedView commit details