Improving pt_BR Providers #545

igorsantos07 · 2015-03-22T19:09:56Z

In overall, code extensibility was improved;
Added some Brazilian documents to the Person provider;
Phone generation was greatly improved, being able to differentiate between landline and cellphones + additional local rules for valid numbers.
added samples to the repository README

New version of #335, with CS and other fixes

Code extensibility was improved by changing private property to protected; Additional methods to generate some Brazilian documents were included

PhoneNumber was rewritten to enable different phone rules in Brazil. Now it generated area codes, landline and cellphone numbers, obeying the rules for the new digit that was added in the last years (and will still be added in the future). The formats are now local-only, like the original PhoneNumber class.

Conflicts: readme.md

…ic tests

- several CS fixes - improved strategy for random selection of phone types - improved default values for formatting - not overwriting phoneNumber() signature anymore; a phoneNumberCleared() was added instead

- added changes on phoneNumber/phoneNumberCleared - fixed typo

fzaninotto · 2015-03-23T17:20:50Z

src/Faker/Provider/pt_BR/Person.php

@@ -90,7 +90,7 @@ class Person extends \Faker\Provider\Person



The file permissions have changed, please revert to 644.

igorsantos07 · 2015-03-23T17:59:35Z

It seems the Travis build failed because of composer issues, on PHP 7.

…aker into improved-pt-cherry-picked

hussani · 2015-03-31T19:17:03Z

src/Faker/Provider/pt_BR/Person.php

+     * @param bool $formatted If the number should have dots/slashes/dashes or not.
+     * @return string
+     */
+    public function cnpj($formatted = true)


CNPJ is a Company property, not Person.
Can you move it?

I'm not really sure if we need to create a whole new provider just to generate company documents. Even more if you consider that's a juridic person document, same as the CPF for a physical person.

Here are the company provider.
https://github.com/fzaninotto/Faker/blob/master/src/Faker/Provider/pt_BR/Company.php

A juridic person is a company, how said on Wikipedia, CNPJ is an identification number to companies and legal entities. I think is more logical move this property to company provider.

Eg.
I, as a person, have a CPF
I, as a company, have a CNPJ

I don't know if it make sense for you. Please, tell me what you think about it.

- CNPJ is a company document, thus the move - check digit function was properly named, and moved into a separate file, as it's used by both classes. Furthermore, as the check digit algorithm is particular to Brazil (it's a variation of mod11, with different maximum multipliers given the number length) it was not placed in Faker/Calculator.

@hussani

- Brazilian RG generator was included, as originally request by @hussani and @ianrodrigues at fzaninotto#488 and fzaninotto#551 - Check digit PHPDoc was included, moving in validation links from CPF and CNPJ generators

oliveiraev · 2015-04-01T15:01:01Z

I, particularly, disagree with an RG generator. RG doesn't follows any pattern across the states. While RG's in São Paulo matches \d{1,3}\.\d{3}\.\d{3}-[0-9x], RG's in Minas Gerais follow something near \d{4,}[A-Z] and no state provides any validator or algorithm checker to avoid generate real persons documents.

igorsantos07 · 2015-04-01T20:41:07Z

I guess there's no such a thing as an algorithm to avoid real documents
whatsoever.

Usually RG is accepted as plain text across systems. On top of that, it's
semantically better to have something like an RG method instead of a random
number generator.

If someone needs a specific state's version, one can simply PR an algorithm
flag :)
I should also add that the algorithm used covers SP and RJ needs, to say
the least.
On 1 Apr 2015 12:01, "Evandro Oliveira" notifications@github.com wrote:

I, particularly, disagree with an RG generator. RG doesn't follows any
pattern across the states. While RG's in São Paulo matches
\d{1,3}.\d{3}.\d{3}-[0-9x], RG's in Minas Gerais follow something near
\d{4,}[A-Z] and no state provides any validator or algorithm checker to
avoid generate real persons documents.

—
Reply to this email directly or view it on GitHub
#545 (comment).

igorsantos07 · 2015-04-23T22:34:58Z

Any news on this, @fzaninotto?

fzaninotto · 2015-04-27T20:10:25Z

test/Faker/Provider/pt_BR/PersonTest.php

+    public function testRgFormatIsValid()
+    {
+        $rg = $this->faker->rg(false);
+        echo $rg."\n";


please remove

fzaninotto · 2015-04-27T20:10:32Z

test/Faker/Provider/pt_BR/PersonTest.php

+        echo $rg."\n";
+        $this->assertRegExp('/\d{8}\d/', $rg);
+        $rg = $this->faker->rg(true);
+        echo $rg."\n";


please remove

fzaninotto · 2015-04-27T20:12:09Z

Good PR, I'll merge as soon as you fix the two minor debug statements.

igorsantos07 · 2015-04-29T03:25:27Z

Whoops! Fixed now.

igorsantos07 · 2015-05-08T18:59:47Z

@fzaninotto, stuff is fixed ;)

Improving pt_BR Providers

fzaninotto · 2015-05-19T10:35:14Z

Thanks!

igorsantos07 added 8 commits March 22, 2015 13:36

Improving code and adding documents

6df5498

Code extensibility was improved by changing private property to protected; Additional methods to generate some Brazilian documents were included

Adding documentation about pt_BR providers

fa21d04

Conflicts: readme.md

Including future ninth digit area codes

8cae5bb

Improving readability of Brazilian document generators and adding bas…

df641cd

…ic tests

Several fixes to brazilian phone generator

cf9daf3

- several CS fixes - improved strategy for random selection of phone types - improved default values for formatting - not overwriting phoneNumber() signature anymore; a phoneNumberCleared() was added instead

Updating brazilian generators doc

c874c02

- added changes on phoneNumber/phoneNumberCleared - fixed typo

Small code style fixes

5322f13

igorsantos07 force-pushed the improved-pt-cherry-picked branch from c630bef to 5322f13 Compare March 22, 2015 19:19

igorsantos07 added 3 commits March 22, 2015 16:24

Small code style fixes

1085695

Brazilian PhoneNumber::areaCode() should be static

615483d

Adding retrocompat with PHP 5.3 on dynamic static calls

9518fe8

fzaninotto reviewed Mar 23, 2015
View reviewed changes

igorsantos07 added 2 commits March 23, 2015 14:43

Fixing file permissions

4aaf031

Adding explain links about brazilian document algorithms

bf30f7b

igorsantos07 added 2 commits March 28, 2015 22:42

Improving pt_BR examples

13daec1

Merge branch 'improved-pt-cherry-picked' of github.com:igorsantos07/F…

05bae3c

…aker into improved-pt-cherry-picked

hussani reviewed Mar 31, 2015
View reviewed changes

igorsantos07 mentioned this pull request Mar 31, 2015

[pt_BR][Person] Adding brazillian RG and CPF #551

Closed

igorsantos07 added 2 commits April 1, 2015 02:14

Adding pt_BR RG and improving docs

5454bee

- Brazilian RG generator was included, as originally request by @hussani and @ianrodrigues at fzaninotto#488 and fzaninotto#551 - Check digit PHPDoc was included, moving in validation links from CPF and CNPJ generators

igorsantos07 force-pushed the improved-pt-cherry-picked branch from c77558b to 5454bee Compare April 1, 2015 05:14

igorsantos07 mentioned this pull request Apr 1, 2015

Improve CPF generation and including RG igorsantos07/Faker#1

Closed

fzaninotto reviewed Apr 27, 2015
View reviewed changes

fzaninotto mentioned this pull request Apr 27, 2015

Added brazilian RG and CPF support #488

Closed

removing debug statements

6aeea1f

fzaninotto added a commit that referenced this pull request May 19, 2015

Merge pull request #545 from igorsantos07/improved-pt-cherry-picked

0ae75f0

Improving pt_BR Providers

fzaninotto merged commit 0ae75f0 into fzaninotto:master May 19, 2015

fzaninotto mentioned this pull request May 19, 2015

Added CPF and CNPJ in pt_BR provider #574

Closed

acfreitas mentioned this pull request May 19, 2015

National Registry of Legal Entities (CNPJ) and Natural Persons Register (CPF) #573

Closed

igorsantos07 deleted the improved-pt-cherry-picked branch September 10, 2015 17:27

igorsantos07 mentioned this pull request Oct 14, 2019

Qual o intuito de um provider separado do Faker com as mesmas funcionalidades? jansenfelipe/faker-br#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improving pt_BR Providers #545

Improving pt_BR Providers #545

igorsantos07 commented Mar 22, 2015

fzaninotto Mar 23, 2015

igorsantos07 commented Mar 23, 2015

hussani Mar 31, 2015

igorsantos07 Mar 31, 2015

hussani Mar 31, 2015

oliveiraev commented Apr 1, 2015

igorsantos07 commented Apr 1, 2015

igorsantos07 commented Apr 23, 2015

fzaninotto Apr 27, 2015

fzaninotto Apr 27, 2015

fzaninotto commented Apr 27, 2015

igorsantos07 commented Apr 29, 2015

igorsantos07 commented May 8, 2015

fzaninotto commented May 19, 2015

		@@ -90,7 +90,7 @@ class Person extends \Faker\Provider\Person

Improving pt_BR Providers #545

Improving pt_BR Providers #545

Conversation

igorsantos07 commented Mar 22, 2015

fzaninotto Mar 23, 2015

Choose a reason for hiding this comment

igorsantos07 commented Mar 23, 2015

hussani Mar 31, 2015

Choose a reason for hiding this comment

igorsantos07 Mar 31, 2015

Choose a reason for hiding this comment

hussani Mar 31, 2015

Choose a reason for hiding this comment

oliveiraev commented Apr 1, 2015

igorsantos07 commented Apr 1, 2015

igorsantos07 commented Apr 23, 2015

fzaninotto Apr 27, 2015

Choose a reason for hiding this comment

fzaninotto Apr 27, 2015

Choose a reason for hiding this comment

fzaninotto commented Apr 27, 2015

igorsantos07 commented Apr 29, 2015

igorsantos07 commented May 8, 2015

fzaninotto commented May 19, 2015