[pt_BR][Person] Adding brazillian RG and CPF #551
Conversation
hussani
force-pushed
the
adding-rg-and-cpf
branch
from
4751d0f
to
53ed467
Compare
|
Is the code working? The samples doesn't seems to reflect the code behaviour - furthermore, that behaviour of passing a string into a provider's method is uncommon across the library. Finally, considering there's an year-old PR (#545) about brazilian documents and other improvements, maybe we should add the RG to it instead of having two PR on the same matter? |
|
@igorsantos07 I just needed a RG and CPF provider and I saw the open PRs, found one and fix. Your solution is larger, have some details inexistent on this PR (like CNPJ and others) and the code is more organized. |
|
You can make a PR to igorsantos07:improved-pt-cherry-picked and I'll merge it. That will include your commit into #545 :) |
- Brazilian RG generator was included, as originally request by @hussani and @ianrodrigues at fzaninotto#488 and fzaninotto#551 - Check digit PHPDoc was included, moving in validation links from CPF and CNPJ generators
- Brazilian RG generator was included, as originally request by @hussani and @ianrodrigues at fzaninotto#488 and fzaninotto#551 - Check digit PHPDoc was included, moving in validation links from CPF and CNPJ generators
|
Superseded by #545. Please collaborate with @igorsantos07 |
This PR is a quick fix of #488, initialized by @ianrodrigues.
All credits belong to him.