Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues regarding localization #218

Closed
9 tasks done
stefandesu opened this issue Dec 5, 2018 · 1 comment
Closed
9 tasks done

Issues regarding localization #218

stefandesu opened this issue Dec 5, 2018 · 1 comment
Labels
cleanup code cleanup, refactoring, testing... question Further discussion needed
Milestone
1.0.0

Comments

@stefandesu
Copy link
Member

stefandesu commented Dec 5, 2018 •
edited
Loading

A small issue collection in regards to localization:

  • mapping types are not localized (Localize mapping types jskos-tools#9)
  • editorial/scope notes need a proper German name
  • MappingBrowser: "show more" tooltip should have proper registry name
  • remove hardcoded .en or .de and replace with util.lmContent
  • adjust MappingsApp -> MappingsApp is deprecated anyway and will be replaced soon
  • ItemDetail title
  • move language selection to Settings (together with Split settings into tabs #173)
  • question: do we still need a language in the config file, and if yes what does it do?
  • question: do we need a separate fallbackLanguage config entry or do we use the language entry or do we use a hardcoded "en"?

Feel free to add more small changes to this.
@stefandesu stefandesu added question Further discussion needed cleanup code cleanup, refactoring, testing... labels Dec 5, 2018
@stefandesu stefandesu added this to the 1.0.0 milestone Dec 5, 2018
@stefandesu stefandesu mentioned this issue Dec 20, 2018
Closed
stefandesu added a commit that referenced this issue Dec 20, 2018
@stefandesu
MappingBrowser: Show registry name on "show more" hover (#218)
8d224f5
stefandesu added a commit that referenced this issue Jan 4, 2019
@stefandesu
Move language selection from Navbar to Settings (#218)
866f1a4
stefandesu added a commit that referenced this issue Jun 24, 2019
@stefandesu
Remove all hardcoded language references (#218)
09a5805
@stefandesu
Copy link
Member Author

I'm closing this even though editorial/scope notes don't have a proper German name. If there is one, please adjust it in config/locale.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup code cleanup, refactoring, testing... question Further discussion needed
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@stefandesu