Move language selection from Navbar to Settings (#218)

gbv · Jan 4, 2019 · 866f1a4 · 866f1a4
1 parent e689ddc
commit 866f1a4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 11 deletions.
diff --git a/config/locale.json b/config/locale.json
@@ -107,6 +107,7 @@
       "tabLayout": "Layout",
       "tabSources": "Data Sources",
       "tabLocalMappings": "Local Mappings",
+      "language": "Interface Language",
       "showAllAncestors": "Always show all ancestors in concept details.",
       "truncateNotes": "Do not truncate notes in concept details.",
       "showAll": "Always show all mappings and suggestions in mapping browser.",
@@ -197,6 +198,7 @@
       "tabLayout": "Layout",
       "tabSources": "Datenquellen",
       "tabLocalMappings": "Lokale Mappings",
+      "language": "Sprache der Oberfläche",
       "showAllAncestors": "Immer alle übergeordneten Konzepte anzeigen.",
       "truncateNotes": "Notizen für Konzepte nicht abschneiden.",
       "showAll": "Immer alle Mappings und Vorschläge anzeigen.",

diff --git a/src/components/TheNavbar.vue b/src/components/TheNavbar.vue
@@ -19,17 +19,6 @@
     </b-navbar-brand>
     <!-- Links on right side -->
     <b-navbar-nav class="ml-auto">
-      <b-nav-item-dropdown
-        :text="config.languages[$i18n.locale] || '?'"
-        right>
-        <b-dropdown-item
-          v-for="(label, language) in config.languages"
-          :key="language"
-          href="#"
-          @click="$i18n.locale = language">
-          {{ label }}
-        </b-dropdown-item>
-      </b-nav-item-dropdown>
       <!-- Feedback button -->
       <b-nav-item
         v-if="config.feedbackUrl"

diff --git a/src/components/TheSettings.vue b/src/components/TheSettings.vue
@@ -16,6 +16,17 @@
         <b-tab
           :title="$t('settings.tabAccount')"
           active>
+          <p>
+            <b>{{ $t("settings.language") }}</b>
+            <b-form-select v-model="$i18n.locale">
+              <option
+                v-for="(label, language) in config.languages"
+                :key="language"
+                :value="language" >
+                {{ label }}
+              </option>
+            </b-form-select>
+          </p>
           <p v-if="localSettings">
             <b>{{ $t("settings.creator") }}</b>
             <b-form-input