Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: seperate build & runtime scriptable options configure() #1046

Merged
merged 31 commits into from
Nov 10, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 25, 2022

closes #609

  • adds build-time ScriptableOptionsConfiguration class
  • renames PerformanceAutoInstrumentation option with PerformanceAutoInstrumentationEnabled and makes it part of SentryUnityOptions
  • fixes SetScript() after a new custom configuration script is created through Editor window UI
  • moves integration test configuration BuildtimeOptions.Configure() and RuntimeOptions.Configure()
  • docs update PR: unity: programmatic configuration changes sentry-docs#5738

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ba040e7

@vaind vaind force-pushed the rework/scriptable-options branch 2 times, most recently from 27c1b06 to 098d4a8 Compare November 4, 2022 17:52
@vaind
Copy link
Collaborator Author

vaind commented Nov 4, 2022

If we wanted to have this covered in integration test, we could use the ConfigureAtBuild() instead of this script: https://github.com/getsentry/sentry-unity/blob/d1c049150eae6a3f6fe0a530e24a3fe8ef84c3cf/test/Scripts.Integration.Test/configure-sentry.ps1 - and our build would also be a little faster

WDYT @bitsandfoxes ?

@vaind vaind marked this pull request as ready for review November 4, 2022 17:58
@bitsandfoxes
Copy link
Contributor

If we wanted to have this covered in integration test, we could use the ConfigureAtBuild() instead of this script:

That's a fantastic idea!

bitsandfoxes
bitsandfoxes previously approved these changes Nov 7, 2022
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the not throwing this looks great to me!
We're gonna break all the people with this, aren't we?

@bitsandfoxes bitsandfoxes self-requested a review November 10, 2022 14:17
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure 🔥 !

@vaind vaind merged commit b37e981 into main Nov 10, 2022
@vaind vaind deleted the rework/scriptable-options branch November 10, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting Options parameters programmatically for use during build time
3 participants