Feat(apple): Add cocoapods support #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
…try-wizard into feat/apple-support
…try-wizard into feat/apple-support
Co-authored-by: Philipp Hofmann <ph.hofmann@pm.me>
…try-wizard into feat/apple-support
|
Lms24
reviewed
Jul 11, 2023
Closed
brustolin
commented
Jul 12, 2023
philipphofmann
approved these changes
Jul 13, 2023
| ); | ||
|
|
||
| try { | ||
| await bash.execute("pod install --silent"); |
There was a problem hiding this comment.
m: Why --silent? Don't we show that to the user? If there is a problem, the user doesn't get the error message.
There was a problem hiding this comment.
The wizard has a nice UI, If I dont use --sillent, pod install will spill a lot of text and break the flow.
If it fails we suggest the user to run the command themself to figure it out whats happening, the project will be already setup anyway. No need to run wizard again.
Co-authored-by: Philipp Hofmann <ph.hofmann@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cocoapods support for the iOS wizard.
If the user has a Podfile, the wizard will add reference to Sentry with CocoaPod instead of SPM.