Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(apple): Add cocoapods support #350

Merged
merged 35 commits into from
Jul 18, 2023
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
fedfcc2
iOS Support
brustolin Jul 5, 2023
460207b
Merge branch 'master' into feat/apple-support
brustolin Jul 5, 2023
30244d0
Delete launch.json
brustolin Jul 5, 2023
2510c4f
Update CHANGELOG.md
brustolin Jul 5, 2023
b260076
Update bin.ts
brustolin Jul 5, 2023
09c22cf
Update code-tools.ts
brustolin Jul 5, 2023
67c2e9f
Update ChooseIntegration.ts
brustolin Jul 5, 2023
1a1c17e
Apply suggestions from code review
brustolin Jul 6, 2023
c7acc22
some fixes
brustolin Jul 6, 2023
6aca98c
Merge branch 'feat/apple-support' of https://github.com/getsentry/sen…
brustolin Jul 6, 2023
af68bc3
Update apple-wizard.ts
brustolin Jul 6, 2023
819317a
Merge branch 'master' into feat/apple-support
brustolin Jul 6, 2023
db2c85d
Update Constants.ts
brustolin Jul 6, 2023
8b693e5
Merge branch 'feat/apple-support' of https://github.com/getsentry/sen…
brustolin Jul 6, 2023
f0303d5
Apply suggestions from code review
brustolin Jul 6, 2023
5ed26db
Merge branch 'master' into feat/apple-support
brustolin Jul 7, 2023
24d6664
multiple projects in the same folder
brustolin Jul 7, 2023
12aefe2
Merge branch 'feat/apple-support' of https://github.com/getsentry/sen…
brustolin Jul 7, 2023
1c754f0
Update CHANGELOG.md
brustolin Jul 7, 2023
ae9bac2
Update xcode-manager.ts
brustolin Jul 7, 2023
f03f50a
Update xcode-manager.ts
brustolin Jul 7, 2023
c9ca7c8
telemetry
brustolin Jul 10, 2023
b70a26e
Update Wizard.ts
brustolin Jul 10, 2023
44b8bde
Update Wizard.ts
brustolin Jul 10, 2023
1aa78f8
cocoapod
brustolin Jul 11, 2023
bb873de
Merge branch 'master' into feat(apple)/cocoapods-support
brustolin Jul 11, 2023
bca6884
Update CHANGELOG.md
brustolin Jul 11, 2023
7ab0085
Merge branch 'master' into feat(apple)/cocoapods-support
brustolin Jul 11, 2023
0cc6efd
Update cocoapod.ts
brustolin Jul 11, 2023
87b41af
Update src/apple/cocoapod.ts
brustolin Jul 12, 2023
1ddaea7
Merge branch 'master' into feat(apple)/cocoapods-support
brustolin Jul 12, 2023
561bded
Update CHANGELOG.md
brustolin Jul 12, 2023
66e04d6
Merge branch 'master' into feat(apple)/cocoapods-support
brustolin Jul 18, 2023
fddea2a
Merge branch 'master' into feat(apple)/cocoapods-support
brustolin Jul 18, 2023
238d0b7
Apply suggestions from code review
brustolin Jul 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/apple/cocoapod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import * as Sentry from '@sentry/node';
// @ts-ignore - clack is ESM and TS complains about that. It works though
import * as clack from '@clack/prompts';
import { traceStep } from '../telemetry';

Check failure on line 7 in src/apple/cocoapod.ts

View workflow job for this annotation

GitHub Actions / Lint

'traceStep' is defined but never used
brustolin marked this conversation as resolved.
Show resolved Hide resolved

export function usesCocoaPod(projPath: string): boolean {
return fs.existsSync(path.join(projPath, 'Podfile'));
Expand Down Expand Up @@ -49,7 +50,7 @@
} catch (e) {
clack.log.error("'pod install' failed. You will need to run it manually.");
loginSpinner.stop();
Sentry.captureException(e);
Sentry.captureException("Sentry pod install failed.");
}

return true;
Expand Down
Loading