-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(onboarding): Consolidate Manual button in integrations #77795
base: master
Are you sure you want to change the base?
ref(onboarding): Consolidate Manual button in integrations #77795
Conversation
…ttons-instrumentation-code
Bundle ReportChanges will increase total bundle size by 29.24MB (100.0%) ⬆️
|
import {getInstallConfig, getSdkInitSnippet} from 'sentry/utils/gettingStartedDocs/node'; | ||
|
||
type Params = DocsParams; | ||
export enum InstallationMode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this repetition very verbose and have the feeling we could make it more reusable 🤔
* Used to show the installation mode for certain platforms, e.g. manual or auto. | ||
* This is defined inside of a platform file | ||
*/ | ||
installationMode: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more refactoring is needed, I would like to get this from the hook useLoadGettingStarted
but added this here for now.
@@ -31,6 +36,7 @@ export function useOnboardingQueryParams(): [ | |||
product: decodeList, | |||
showLoader: decodeBoolean, | |||
showManualSetup: decodeBoolean, | |||
installationMode: decodeScalar, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also it would be better to return MANUAL
or AUTO
from an enum but I did not want to add a custom decode
here now
if (!docsConfig || !dsn || !projectKeyId) { | ||
return ( | ||
<LoadingError | ||
message={t( | ||
'The getting started documentation for this platform is currently unavailable.' | ||
)} | ||
onRetry={refetch} | ||
/> | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, we might consider moving this to the parent component, as we currently have the same check within SdkDocumentation
Screen.Recording.2024-09-20.at.14.41.59.mov
closes #77538