-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(onboarding): Consolidate Manual button in integrations #77795
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,16 @@ | ||
import {useCallback} from 'react'; | ||
|
||
import {decodeBoolean, decodeList} from 'sentry/utils/queryString'; | ||
import {decodeBoolean, decodeList, decodeScalar} from 'sentry/utils/queryString'; | ||
import useLocationQuery from 'sentry/utils/url/useLocationQuery'; | ||
import {useLocation} from 'sentry/utils/useLocation'; | ||
import {useNavigate} from 'sentry/utils/useNavigate'; | ||
|
||
type QueryValues = { | ||
/** | ||
* Used to show the installation mode for certain platforms, e.g. manual or auto. | ||
* This is defined inside of a platform file | ||
*/ | ||
installationMode: string; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. more refactoring is needed, I would like to get this from the hook |
||
/** | ||
* Used to show product selection (error monitoring, tracing, profiling and session replay) for certain platforms, e.g. javascript-react | ||
*/ | ||
|
@@ -31,6 +36,7 @@ export function useOnboardingQueryParams(): [ | |
product: decodeList, | ||
showLoader: decodeBoolean, | ||
showManualSetup: decodeBoolean, | ||
installationMode: decodeScalar, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also it would be better to return |
||
}, | ||
}); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this repetition very verbose and have the feeling we could make it more reusable 🤔