Add http.Replace() and use it for file servers #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix, I will release v3.4.3 once it is merged. I just have one question: would it make sense to refactor |
tchssk
force-pushed
the
v3-http-file-server-replace
branch
from
b87eed9
to
c402686
Compare
|
I integrated ReplacePrefix into Replace. An additional commit is a fix for |
|
This is great thank you! |
|
Would you release v3.4.3? Thank you! |
|
Yes I will as soon as #2858 is merged. |
|
I just released v3.4.3 as it's going to take a bit more time to finalize #2858. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix of #2839.
I'm glad if you release v3.4.3 after merging this. Thank you.