Refactor file server implementation #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it doesn't require introducing a `Replace` function. The new implementation is more robust and properly handles cases where the file path is deep and differs from the mount path.
|
This code cannot handle cases where the filename is different between request and file system. Files("/index.html", "/www/data/another.html") |
|
Whoops, yes that makes sense, I think we can modify the generated |
raphael
added a commit
that referenced
this pull request
Sep 18, 2024
This fixes a regression introduced by #3588 that broke the generation of file servers when the served filename differs from the request path filename, .e.g: Files(/index.html, /www/data/another.html)
|
Would you be able to test #3593 to see if its fixes the issue? Thank you! |
raphael
added a commit
that referenced
this pull request
Sep 21, 2024
This fixes a regression introduced by #3588 that broke the generation of file servers when the served filename differs from the request path filename, .e.g: Files(/index.html, /www/data/another.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that it doesn't require introducing a
Replacefunction. The new implementation is more robust and properly handles cases where the file path is deep and differs from the mount path.