Migrating from generate-groups.sh to kube_codegen.sh #3722

Kalaiselvi84 · 2024-03-20T05:43:55Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3659

Special notes for your reviewer:

agones-bot · 2024-03-20T06:52:11Z

Build Succeeded 👏

Build Id: e48cd1db-5e3f-4e59-8078-b169c98aa3a3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://6b54521-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3722/head:pr_3722 && git checkout pr_3722
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-6b54521-amd64

Kalaiselvi84 · 2024-03-20T21:19:48Z

The make gen-crd-client command did not result in any changes in the files during this migration. The update to ForceUpdate 13 in the build/build-images/Dockerfile involves the use of the kubecode_gen.sh file

zmerlynn · 2024-03-20T21:23:07Z

Provisional LGTM, will approve when I see that test-gen-crd-client is actually using it this time. :)

agones-bot · 2024-03-20T21:23:55Z

Build Failed 😱

Build Id: e3fb8ffe-0e28-4346-9071-fbc287647d7c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn · 2024-03-20T21:25:13Z

diff: ../pkg/client: No such file or directory

github-actions · 2024-03-20T21:54:00Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-03-20T21:55:53Z

Build Failed 😱

Build Id: af3479a5-c48f-4419-a0c5-4d465e84aa2b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

This reverts commit 5902e23.

agones-bot · 2024-03-20T22:20:44Z

Build Failed 😱

Build Id: 5a15b4f5-40c1-401a-b7a1-b01b30172571

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-03-21T03:32:16Z

Build Failed 😱

Build Id: 2fe5cc1f-5781-45d4-8bcd-d507ac66f2b0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-03-21T18:25:19Z

Build Failed 😱

Build Id: da286508-4fd7-452f-b3fa-fe6595e9ff03

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-03-21T18:38:58Z

Build Failed 😱

Build Id: 34ba9772-8305-4913-81a3-b59c2381a117

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-03-21T20:33:00Z

Build Failed 😱

Build Id: 8a1afead-68dc-41a4-b222-87d34e3c82db

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-03-21T22:57:48Z

Build Failed 😱

Build Id: 0013606b-d348-4913-8ba7-73368dae3ca2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn · 2024-03-21T23:38:55Z

build/build-image/gen-crd-client.sh

+echo "Checking if the tag v0.30.0-beta.0 exists..."
+if git show-ref --tags | grep -q "refs/tags/v0.30.0-beta.0"; then
+    echo "Tag found. Checking out v0.30.0-beta.0..."
+    git checkout v0.30.0-beta.0


instead of doing all this, just do this:

change line 63 of build/build-image/Dockerfile:

copy and paste the old line so we have it around for when we revert this, comment out the copy

Instead of -b kubernetes-${KUBERNETES_VER}, just do -b v0.30.0-beta.0

Leave a note at line 53 that whenever we bump k8s versions next, consider bumping the pinned version. For the 1.29 bump we may just move code-gen to the GA'd v1.30 tag, but once we bump to 1.30, we should stop pinning it.

I've made the necessary changes to the build/build-image/Dockerfile and refined the gen-crd-client.sh script. Also, I did not bump the ForceUpdate in the Dockerfile.

zmerlynn

Mostly a nit about which layer the tag is at but LGTM otherwise. The diff below is tiny.

ETA: It looks like the build failure was a unit test flake, too.

agones-bot · 2024-03-22T00:33:57Z

Build Succeeded 👏

Build Id: 364b4613-bfa5-4340-9c2f-99555de5b1d9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://77af48a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3722/head:pr_3722 && git checkout pr_3722
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-77af48a-amd64

Minor edits to the Dockerfile

agones-bot · 2024-03-22T02:17:35Z

Build Succeeded 👏

Build Id: e57b6439-b1a9-448c-aebc-246514e7d2e1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://9308cbc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3722/head:pr_3722 && git checkout pr_3722
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-9308cbc-amd64

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.39.0` -> `1.40.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.40.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1400-2024-04-23) [Compare Source](https://github.com/googleforgames/agones/compare/v1.39.0...v1.40.0) [Full Changelog](https://github.com/googleforgames/agones/compare/v1.39.0...v1.40.0) **Breaking changes:** - Counters and Lists: Remove Bool Returns by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3738 **Implemented enhancements:** - Leader Election in Custom Controller by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3696 - Migrating from generate-groups.sh to kube_codegen.sh by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3722 - Move GKEAutopilotExtendedDurationPods to Alpha in 1.28+ by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3729 - Move DisableResyncOnSDKServer to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3732 - Counters & Lists landing page and doc improvements by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3649 - Graduate FleetAllocationOverflow to Stable by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3733 - Adds Counters and Lists to CSharp SDK by [@igooch](https://github.com/igooch) in [googleforgames/agones#3581 - Feat/counter and list defaulting order to ascending by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3734 - Add handling for StatusAddresses in GameServerStatus for the Unity SDK by [@charlesvien](https://github.com/charlesvien) in [googleforgames/agones#3739 - Feat(gameservers): Shared pod IPs with GameServer Addresses by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3764 - Be prescriptive about rotating regions when updating Kubernetes versions by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3716 - Fix ensure-e2e-infra-state-bucket by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3719 - Create Performance Cluster 1.28 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3720 - Optimise GameServer Sub-Controller Queues by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3781 **Fixed bugs:** - Counters & Lists: Consolidate `priorities` sorting by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3690 - Fix(Counter & Lists): Add validation for `priorities` by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3714 - fix: [#3607](https://github.com/googleforgames/agones/issues/3607) Metrics data loss in K8S controller by [@alvin-7](https://github.com/alvin-7) in [googleforgames/agones#3692 - Deflake GameServerAllocationDuringMultipleAllocationClients by allowing errors by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3750 **Security fixes:** - Bump protobufjs from 7.2.4 to 7.2.6 in /sdks/nodejs by [@dependabot](https://github.com/dependabot) in [googleforgames/agones#3755 - Bump golang.org/x/net from 0.19.0 to 0.23.0 by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3793 **Other:** - Flaky: TestGameServerCreationAfterDeletingOneExtensionsPod by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3699 - Prep for release v1.40.0 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3700 - Bumps cpp-simple Image and Refactoring Example Makefiles by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3695 - Upgrade Protobuf to 1.33.0 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3711 - Modify Script for Makefile Version Updates in Examples Directory by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3712 - Adds simple genai server example documentation to the Agones site by [@igooch](https://github.com/igooch) in [googleforgames/agones#3713 - Update Supported Kubernetes to 1.27, 1.28, 1.29 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3654 - fix: typo in docs by [@qhyun2](https://github.com/qhyun2) in [googleforgames/agones#3723 - Tweak: Setting up the Game Server by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3717 - Docs: gke.md - spelling by [@daniellee](https://github.com/daniellee) in [googleforgames/agones#3740 - Aesthetic rearrangement of cloudbuild.yaml by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3741 - Docs: Make hitting <enter> on connection explicit by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3743 - CI: Don't check Unreal Link by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3745 - New recommendation for multi-cluster allocation by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3744 - Custom Controller Example Page on Agones Website by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3725 - Add Nitrado logo by [@towolf](https://github.com/towolf) in [googleforgames/agones#3753 - Remove unnecessary args from e2e-test-cloudbuild by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3754 - Update Allocation from Fleet Documentation by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3761 - Transform Lint Warnings into Errors by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3756 - Update Canary Testing Documentation by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3760 - Supertuxkart Example on Agones Site by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3728 - Xonotic Example on Agones Site by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3742 - nit documentation fix in kind cluster section when building Agones by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3770 - Merged steps inside documentation about webhook certificate creation by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3768 - Example Images: Increment Tags by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3796 - Update simple game server example documentation by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3776 **New Contributors:** - [@lacroixthomas](https://github.com/lacroixthomas) made their first contribution in [googleforgames/agones#3714 - [@daniellee](https://github.com/daniellee) made their first contribution in [googleforgames/agones#3740 - [@charlesvien](https://github.com/charlesvien) made their first contribution in [googleforgames/agones#3739 - [@vicentefb](https://github.com/vicentefb) made their first contribution in [googleforgames/agones#3770 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Use kube_codegen.sh

6b54521

github-actions bot added kind/other size/XS labels Mar 20, 2024

Kalaiselvi84 requested a review from zmerlynn March 20, 2024 14:40

Kalaiselvi84 added kind/feature New features for Agones and removed kind/other labels Mar 20, 2024

ForceUpdate 13 to force rebuild

6c96ac1

github-actions bot added the kind/other label Mar 20, 2024

make test-gen-crd-client: deleted pkg/client dir

5902e23

github-actions bot added the size/XL label Mar 20, 2024

Revert "make test-gen-crd-client: deleted pkg/client dir"

3f9ba26

This reverts commit 5902e23.

modify bash script

f04f495

github-actions bot added the size/S label Mar 21, 2024

used loop to compare file content

4b84ec1

revert test-gen-crd-client

1f3e361

modified pkg/client/clientset

a17fefd

update arguments: kube::codegen::gen_client

77af48a

zmerlynn reviewed Mar 21, 2024

View reviewed changes

zmerlynn requested changes Mar 21, 2024

View reviewed changes

Kalaiselvi84 and others added 2 commits March 22, 2024 00:51

pin code-gen version

98b207a

Update Dockerfile

fea339d

Minor edits to the Dockerfile

zmerlynn approved these changes Mar 22, 2024

View reviewed changes

Merge branch 'main' into kube_codegen

9308cbc

zmerlynn enabled auto-merge (squash) March 22, 2024 01:11

zmerlynn merged commit c326a07 into googleforgames:main Mar 22, 2024
4 checks passed

Kalaiselvi84 removed the kind/other label Apr 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrating from generate-groups.sh to kube_codegen.sh #3722

Migrating from generate-groups.sh to kube_codegen.sh #3722

Kalaiselvi84 commented Mar 20, 2024 •

edited

Loading

agones-bot commented Mar 20, 2024

Kalaiselvi84 commented Mar 20, 2024 •

edited

Loading

zmerlynn commented Mar 20, 2024

agones-bot commented Mar 20, 2024

zmerlynn commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

agones-bot commented Mar 20, 2024

agones-bot commented Mar 20, 2024

agones-bot commented Mar 21, 2024

agones-bot commented Mar 21, 2024

agones-bot commented Mar 21, 2024

agones-bot commented Mar 21, 2024

agones-bot commented Mar 21, 2024

zmerlynn Mar 21, 2024

Kalaiselvi84 Mar 22, 2024

zmerlynn left a comment •

edited

Loading

agones-bot commented Mar 22, 2024

agones-bot commented Mar 22, 2024

Migrating from generate-groups.sh to kube_codegen.sh #3722

Migrating from generate-groups.sh to kube_codegen.sh #3722

Conversation

Kalaiselvi84 commented Mar 20, 2024 • edited Loading

agones-bot commented Mar 20, 2024

Kalaiselvi84 commented Mar 20, 2024 • edited Loading

zmerlynn commented Mar 20, 2024

agones-bot commented Mar 20, 2024

zmerlynn commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

agones-bot commented Mar 20, 2024

agones-bot commented Mar 20, 2024

agones-bot commented Mar 21, 2024

agones-bot commented Mar 21, 2024

agones-bot commented Mar 21, 2024

agones-bot commented Mar 21, 2024

agones-bot commented Mar 21, 2024

zmerlynn Mar 21, 2024

Choose a reason for hiding this comment

Kalaiselvi84 Mar 22, 2024

Choose a reason for hiding this comment

zmerlynn left a comment • edited Loading

Choose a reason for hiding this comment

agones-bot commented Mar 22, 2024

agones-bot commented Mar 22, 2024

Kalaiselvi84 commented Mar 20, 2024 •

edited

Loading

Kalaiselvi84 commented Mar 20, 2024 •

edited

Loading

zmerlynn left a comment •

edited

Loading