Graduate FleetAllocationOverflow to Stable #3733

Kalaiselvi84 · 2024-03-27T18:33:35Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3730

Special notes for your reviewer:

github-actions · 2024-03-27T18:33:55Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-03-27T18:41:52Z

Build Failed 😱

Build Id: 4f3fa4a0-96e5-47b9-9976-d80165f1a6ab

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-03-27T18:55:34Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-03-27T20:23:27Z

Build Succeeded 👏

Build Id: 580f93e2-b1c4-4f1c-8e5b-e7ac632fa05e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://9e7451a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3733/head:pr_3733 && git checkout pr_3733
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-9e7451a-amd64

github-actions · 2024-03-27T20:33:35Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Kalaiselvi84 · 2024-03-27T20:35:03Z

site/content/en/docs/Guides/feature-stages.md

@@ -39,8 +39,8 @@ The current set of `alpha` and `beta` feature gates:
 {{% feature publishVersion="1.40.0" %}}
 | Feature Name                                                                                                                | Gate                               | Default  | Stage   | Since  |
 |-----------------------------------------------------------------------------------------------------------------------------|------------------------------------|----------|---------|--------|
+| [Allocated GameServers are notified on relevant Fleet Updates][fleet-updates]                                               | `FleetAllocationOverflow`          | Enabled  | `Stable`| 1.40.0 |


Would placing the stable feature on top be better?

We don't record Stable features (or we'd have a lot more here), so the line should just be deleted.

Thanks for letting me know. I have deleted this line👍🏻

agones-bot · 2024-03-27T21:24:23Z

Build Failed 😱

Build Id: 363e614a-8252-489f-952b-40e759c7cc2f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-03-27T22:32:44Z

Build Succeeded 👏

Build Id: 58c37e04-1b28-4db8-b3a4-fc5424e74b3a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://dae1361-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3733/head:pr_3733 && git checkout pr_3733
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-dae1361-amd64

zmerlynn

A couple of nits - looks like you have conflicts as well. Resolve both and I'll happily merge!

pkg/util/runtime/features.go

zmerlynn · 2024-03-29T23:15:00Z

site/content/en/docs/Guides/feature-stages.md

@@ -39,8 +39,8 @@ The current set of `alpha` and `beta` feature gates:
 {{% feature publishVersion="1.40.0" %}}
 | Feature Name                                                                                                                | Gate                               | Default  | Stage   | Since  |
 |-----------------------------------------------------------------------------------------------------------------------------|------------------------------------|----------|---------|--------|
+| [Allocated GameServers are notified on relevant Fleet Updates][fleet-updates]                                               | `FleetAllocationOverflow`          | Enabled  | `Stable`| 1.40.0 |


We don't record Stable features (or we'd have a lot more here), so the line should just be deleted.

github-actions · 2024-03-29T23:46:05Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2024-03-29T23:51:06Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-03-30T01:02:05Z

Build Succeeded 👏

Build Id: 39cfbb36-90ed-4733-bddd-5a0c4771abda

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://3077cdf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3733/head:pr_3733 && git checkout pr_3733
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-3077cdf-amd64

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.39.0` -> `1.40.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.40.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1400-2024-04-23) [Compare Source](https://github.com/googleforgames/agones/compare/v1.39.0...v1.40.0) [Full Changelog](https://github.com/googleforgames/agones/compare/v1.39.0...v1.40.0) **Breaking changes:** - Counters and Lists: Remove Bool Returns by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3738 **Implemented enhancements:** - Leader Election in Custom Controller by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3696 - Migrating from generate-groups.sh to kube_codegen.sh by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3722 - Move GKEAutopilotExtendedDurationPods to Alpha in 1.28+ by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3729 - Move DisableResyncOnSDKServer to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3732 - Counters & Lists landing page and doc improvements by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3649 - Graduate FleetAllocationOverflow to Stable by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3733 - Adds Counters and Lists to CSharp SDK by [@igooch](https://github.com/igooch) in [googleforgames/agones#3581 - Feat/counter and list defaulting order to ascending by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3734 - Add handling for StatusAddresses in GameServerStatus for the Unity SDK by [@charlesvien](https://github.com/charlesvien) in [googleforgames/agones#3739 - Feat(gameservers): Shared pod IPs with GameServer Addresses by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3764 - Be prescriptive about rotating regions when updating Kubernetes versions by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3716 - Fix ensure-e2e-infra-state-bucket by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3719 - Create Performance Cluster 1.28 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3720 - Optimise GameServer Sub-Controller Queues by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3781 **Fixed bugs:** - Counters & Lists: Consolidate `priorities` sorting by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3690 - Fix(Counter & Lists): Add validation for `priorities` by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3714 - fix: [#3607](https://github.com/googleforgames/agones/issues/3607) Metrics data loss in K8S controller by [@alvin-7](https://github.com/alvin-7) in [googleforgames/agones#3692 - Deflake GameServerAllocationDuringMultipleAllocationClients by allowing errors by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3750 **Security fixes:** - Bump protobufjs from 7.2.4 to 7.2.6 in /sdks/nodejs by [@dependabot](https://github.com/dependabot) in [googleforgames/agones#3755 - Bump golang.org/x/net from 0.19.0 to 0.23.0 by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3793 **Other:** - Flaky: TestGameServerCreationAfterDeletingOneExtensionsPod by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3699 - Prep for release v1.40.0 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3700 - Bumps cpp-simple Image and Refactoring Example Makefiles by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3695 - Upgrade Protobuf to 1.33.0 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3711 - Modify Script for Makefile Version Updates in Examples Directory by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3712 - Adds simple genai server example documentation to the Agones site by [@igooch](https://github.com/igooch) in [googleforgames/agones#3713 - Update Supported Kubernetes to 1.27, 1.28, 1.29 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3654 - fix: typo in docs by [@qhyun2](https://github.com/qhyun2) in [googleforgames/agones#3723 - Tweak: Setting up the Game Server by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3717 - Docs: gke.md - spelling by [@daniellee](https://github.com/daniellee) in [googleforgames/agones#3740 - Aesthetic rearrangement of cloudbuild.yaml by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3741 - Docs: Make hitting <enter> on connection explicit by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3743 - CI: Don't check Unreal Link by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3745 - New recommendation for multi-cluster allocation by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3744 - Custom Controller Example Page on Agones Website by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3725 - Add Nitrado logo by [@towolf](https://github.com/towolf) in [googleforgames/agones#3753 - Remove unnecessary args from e2e-test-cloudbuild by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3754 - Update Allocation from Fleet Documentation by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3761 - Transform Lint Warnings into Errors by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3756 - Update Canary Testing Documentation by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3760 - Supertuxkart Example on Agones Site by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3728 - Xonotic Example on Agones Site by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3742 - nit documentation fix in kind cluster section when building Agones by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3770 - Merged steps inside documentation about webhook certificate creation by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3768 - Example Images: Increment Tags by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3796 - Update simple game server example documentation by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3776 **New Contributors:** - [@lacroixthomas](https://github.com/lacroixthomas) made their first contribution in [googleforgames/agones#3714 - [@daniellee](https://github.com/daniellee) made their first contribution in [googleforgames/agones#3740 - [@charlesvien](https://github.com/charlesvien) made their first contribution in [googleforgames/agones#3739 - [@vicentefb](https://github.com/vicentefb) made their first contribution in [googleforgames/agones#3770 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Graduate FleetAllocationOverflow to Stable

e260da4

Kalaiselvi84 requested review from markmandel and zmerlynn March 27, 2024 18:33

github-actions bot added kind/feature New features for Agones size/XL labels Mar 27, 2024

cleanup controller.go

9e7451a

Merge branch 'main' into fao

dae1361

Kalaiselvi84 commented Mar 27, 2024

View reviewed changes

zmerlynn reviewed Mar 29, 2024

View reviewed changes

Review changes and fix conflict

770ac5a

remove excess new line

890a46b

revert agones_crd_api_reference.html

8c22a1f

github-actions bot added the size/M label Mar 29, 2024

Kalaiselvi84 added 2 commits March 29, 2024 23:56

Merge branch 'main' into fao

fcc57fc

agones_crd_api_refernce.html

3077cdf

zmerlynn approved these changes Mar 30, 2024

View reviewed changes

zmerlynn enabled auto-merge (squash) March 30, 2024 00:01

zmerlynn merged commit 986ed9b into googleforgames:main Mar 30, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Graduate FleetAllocationOverflow to Stable #3733

Graduate FleetAllocationOverflow to Stable #3733

Kalaiselvi84 commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

agones-bot commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

agones-bot commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

Kalaiselvi84 Mar 27, 2024

zmerlynn Mar 29, 2024

Kalaiselvi84 Mar 30, 2024

agones-bot commented Mar 27, 2024

agones-bot commented Mar 27, 2024

zmerlynn left a comment

zmerlynn Mar 29, 2024

github-actions bot commented Mar 29, 2024

github-actions bot commented Mar 29, 2024

agones-bot commented Mar 30, 2024

Graduate FleetAllocationOverflow to Stable #3733

Graduate FleetAllocationOverflow to Stable #3733

Conversation

Kalaiselvi84 commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

agones-bot commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

agones-bot commented Mar 27, 2024

github-actions bot commented Mar 27, 2024

Kalaiselvi84 Mar 27, 2024

Choose a reason for hiding this comment

zmerlynn Mar 29, 2024

Choose a reason for hiding this comment

Kalaiselvi84 Mar 30, 2024

Choose a reason for hiding this comment

agones-bot commented Mar 27, 2024

agones-bot commented Mar 27, 2024

zmerlynn left a comment

Choose a reason for hiding this comment

zmerlynn Mar 29, 2024

Choose a reason for hiding this comment

github-actions bot commented Mar 29, 2024

github-actions bot commented Mar 29, 2024

agones-bot commented Mar 30, 2024