Fix for Dockerfile smell DL3048 #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grosa1 thanks for this! |
Sure! |
Signed-off-by: Giovanni Rosa <giovanni.rosa@unimol.it>
bjw-s
pushed a commit
to bjw-s/dotfiles
that referenced
this pull request
Jul 11, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [helm-ct](https://github.com/helm/chart-testing) | minor | `3.8.0` -> `3.9.0` | --- ### Release Notes <details> <summary>helm/chart-testing (helm-ct)</summary> ### [`v3.9.0`](https://github.com/helm/chart-testing/releases/tag/v3.9.0) [Compare Source](https://github.com/helm/chart-testing/compare/v3.8.0...v3.9.0) ##### What's Changed - update goreleaser flags by [@​cpanato](https://github.com/cpanato) in [helm/chart-testing#539 - feat: verify if targetBranch is present in git repo by [@​fty4](https://github.com/fty4) in [helm/chart-testing#511 - add github grouping of log lines by [@​joejulian](https://github.com/joejulian) in [helm/chart-testing#556 - fix for ct install getting stuck when printing logs: close readers when done with reading by [@​skylenet](https://github.com/skylenet) in [helm/chart-testing#557 - update golangci and helm by [@​cpanato](https://github.com/cpanato) in [helm/chart-testing#575 - add --extra-helm-args to ct lint by [@​AndersBennedsgaard](https://github.com/AndersBennedsgaard) in [helm/chart-testing#552 - Fix for Dockerfile smell DL3048 by [@​grosa1](https://github.com/grosa1) in [helm/chart-testing#543 ##### New Contributors - [@​fty4](https://github.com/fty4) made their first contribution in [helm/chart-testing#511 - [@​joejulian](https://github.com/joejulian) made their first contribution in [helm/chart-testing#556 - [@​skylenet](https://github.com/skylenet) made their first contribution in [helm/chart-testing#557 - [@​AndersBennedsgaard](https://github.com/AndersBennedsgaard) made their first contribution in [helm/chart-testing#552 - [@​grosa1](https://github.com/grosa1) made their first contribution in [helm/chart-testing#543 **Full Changelog**: helm/chart-testing@v3.8.0...v3.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNi42LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: bjw-s-bot <87358111+bjw-s-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change improves the quality of the target Dockerfile in order to follow the recommended Docker writing best practices.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Hi!
The Dockerfile placed at "Dockerfile" contains the best practice violation DL3048 detected by the hadolint tool.
The smell DL3048 occurs when the pattern used for the label keys does not match the format recommended by official guidelines.
In this pull request, we propose a fix for that smell generated by our fixing tool. We verified that the patch is correct before opening the pull request.
To fix this smell, specifically, the label keys are refactored to match the correct format.
This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.
Thanks in advance.