-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for ct install getting stuck when printing logs: close readers when done with reading #557
Merged
cpanato
merged 1 commit into
helm:main
from
skylenet:skylenet/fixup-close-stdout-stderr
Jun 26, 2023
Merged
fix for ct install getting stuck when printing logs: close readers when done with reading #557
cpanato
merged 1 commit into
helm:main
from
skylenet:skylenet/fixup-close-stdout-stderr
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafael Matias <rafael@skyle.net>
barnabasbusa
approved these changes
May 31, 2023
skylenet
force-pushed
the
skylenet/fixup-close-stdout-stderr
branch
from
May 31, 2023 10:57
37afcf1
to
f358bc3
Compare
friendly ping @davidkarlsen @cpanato 🙏 |
Any chance on having someone look at this @davidkarlsen ? |
hi @skylenet - sorry for the delay, merging now. Thanks! |
davidkarlsen
approved these changes
Jun 26, 2023
cpanato
approved these changes
Jun 26, 2023
bjw-s
pushed a commit
to bjw-s/dotfiles
that referenced
this pull request
Jul 11, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [helm-ct](https://github.com/helm/chart-testing) | minor | `3.8.0` -> `3.9.0` | --- ### Release Notes <details> <summary>helm/chart-testing (helm-ct)</summary> ### [`v3.9.0`](https://github.com/helm/chart-testing/releases/tag/v3.9.0) [Compare Source](https://github.com/helm/chart-testing/compare/v3.8.0...v3.9.0) ##### What's Changed - update goreleaser flags by [@​cpanato](https://github.com/cpanato) in [helm/chart-testing#539 - feat: verify if targetBranch is present in git repo by [@​fty4](https://github.com/fty4) in [helm/chart-testing#511 - add github grouping of log lines by [@​joejulian](https://github.com/joejulian) in [helm/chart-testing#556 - fix for ct install getting stuck when printing logs: close readers when done with reading by [@​skylenet](https://github.com/skylenet) in [helm/chart-testing#557 - update golangci and helm by [@​cpanato](https://github.com/cpanato) in [helm/chart-testing#575 - add --extra-helm-args to ct lint by [@​AndersBennedsgaard](https://github.com/AndersBennedsgaard) in [helm/chart-testing#552 - Fix for Dockerfile smell DL3048 by [@​grosa1](https://github.com/grosa1) in [helm/chart-testing#543 ##### New Contributors - [@​fty4](https://github.com/fty4) made their first contribution in [helm/chart-testing#511 - [@​joejulian](https://github.com/joejulian) made their first contribution in [helm/chart-testing#556 - [@​skylenet](https://github.com/skylenet) made their first contribution in [helm/chart-testing#557 - [@​AndersBennedsgaard](https://github.com/AndersBennedsgaard) made their first contribution in [helm/chart-testing#552 - [@​grosa1](https://github.com/grosa1) made their first contribution in [helm/chart-testing#543 **Full Changelog**: helm/chart-testing@v3.8.0...v3.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNi42LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: bjw-s-bot <87358111+bjw-s-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In some cases
kubectl logs ..
was hanging for us. This mainly happened with pods that logged lines with a lot of characters.The fix of closing both pipes after reading them successfully did the trick and we weren't getting stuck anymore.
Which issue this PR fixes *:
There are some closed issue related to this problem:
Special notes for your reviewer:
This is how you can reproduce the stuck kubectl logs:
I've also tried using the kubectl request-timeout to see if the command would exit, but that didn't happen. The only way for it to terminate was to close the io readers.
Example of a command that got stuck :