Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test network nano bash updated with smartbft consensus #923

Closed
wants to merge 3 commits into from
Closed

test network nano bash updated with smartbft consensus #923

wants to merge 3 commits into from

Conversation

Param-S
Copy link
Contributor

@Param-S Param-S commented Jan 31, 2023

It requires the configtxgen & orderer smartbft changes from PR hyperledger/fabric#3781

Signed-off-by: Parameswaran Selvam parselva@in.ibm.com

@Param-S
test network nano bash updated with smartbft consensus
d340f62 
Signed-off-by: Parameswaran Selvam <parselva@in.ibm.com>
@Param-S Param-S requested a review from a team as a code owner January 31, 2023 19:19
@Param-S Param-S marked this pull request as draft January 31, 2023 19:19
@Param-S Param-S changed the title test network nano bash updated with smartbft consensus WIP: test network nano bash updated with smartbft consensus Jan 31, 2023
@Param-S
updated nanonet network.sh with smartbft orderer type
fd3cf67 
Signed-off-by: Parameswaran Selvam <parselva@in.ibm.com>
@Param-S Param-S changed the title WIP: test network nano bash updated with smartbft consensus test network nano bash updated with smartbft consensus Feb 23, 2023
@Param-S Param-S marked this pull request as ready for review February 23, 2023 07:31
@Param-S
Update to use channel participation api
aa33bd6 
Signed-off-by: Parameswaran Selvam <parselva@in.ibm.com>
@yacovm
Copy link
Contributor

yacovm commented Feb 28, 2023

Looks OK-ish but CI fails and someone that is a a maintainer needs to review this

@denyeart
Copy link
Contributor

denyeart commented Mar 8, 2023

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Mar 8, 2023

rebase

❌ Base branch update has failed

User denyeart is unknown, make sure denyeart has logged in Mergify Mergify dashboard.
err-code: 8619D

@denyeart
Copy link
Contributor

denyeart commented Mar 8, 2023 •
edited
Loading

@Param-S Please rebase to pick up the recent fabric-samples fixes and improvements.

Were you planning to make test-network work with SmartBFT? Or just test-network-nano-bash?
test-network-nano-bash does indeed make more sense since it has multiple orderer nodes already, this one was intended for orderer trials, while the regular test-network is meant more for trying applications and therefore only has one orderer node. So I agree with the approach here.

@arkadiPiven arkadiPiven mentioned this pull request May 9, 2023
Merged
@denyeart
Copy link
Contributor

denyeart commented Aug 9, 2023

Completed in #1038

@denyeart denyeart closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yacovm yacovm yacovm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Param-S @yacovm @denyeart