Add SmartBFT consensus support #3781

Param-S · 2022-11-14T12:17:42Z

Type of change

New feature

Description

Add support for BFT consensus to orderer consensus plugin

Additional details

RFC: https://hyperledger.github.io/fabric-rfcs/text/006-bft-based-ordering-service.html

Related issues

EPIC task: #3771

Signed-off-by: Yacov Manevich yacovm@il.ibm.com
Signed-off-by: Yoav Tock tock@il.ibm.com
Signed-off-by: Parameswaran Selvam parselva@in.ibm.com

go.sum

common/policies/bft.go

integration/nwo/components.go

orderer/common/onboarding/onboarding_test.go

orderer/common/server/main.go

yacovm · 2023-02-02T10:46:15Z

orderer/common/multichannel/ledger_resources_test.go

-	// Scenario V: A valid config envelope is passed
-	require.NoError(t, cs.VerifyBlockSignature([]*protoutil.SignedData{}, testConfigEnvelope(t)))
-}
+// func TestLedgerResources_VerifyBlockSignature(t *testing.T) {


why is this commented out?

common/crypto/sanitize.go

common/crypto/signer.go

common/policies/bft.go

integration/nwo/components.go

integration/nwo/network.go

yacovm · 2023-02-07T10:39:21Z

integration/nwo/template/configtx_template.go

@@ -158,19 +158,16 @@ Profiles:{{ range .Profiles }}
        PreferredMaxBytes: 512 KB
      {{- end}}
      Capabilities:
-        {{- if eq $w.Consensus.Type "BFT" }}


why are you deleting this?

Why indeed?

Signed-off-by: Yacov Manevich <yacov.manevich@ibm.com>

Signed-off-by: Parameswaran Selvam <parselva@in.ibm.com>

Signed-off-by: Yacov Manevich <yacov.manevich@ibm.com>

tock-ibm

This is just a quick review of the integration tests.

tock-ibm · 2023-02-20T10:21:52Z

integration/ports.go

@@ -41,6 +41,7 @@ const (
 	PrivateDataPurgeBasePort
 	RaftBasePort
 	SBEBasePort
+	SmartBFTBasePort


Should the SmartBFTBasePort different than the RaftBasePort? In general, that could be renamed the "ConsensusBasePort"?

tock-ibm · 2023-02-20T10:22:03Z

integration/channelparticipation/channel_participation.go

+
+	doBody(client, req)
+
+	Eventually(func() ChannelInfo {
+		return ListOne(n, o, channel)
+	}, n.EventuallyTimeout).Should(Equal(expectedChannelInfo))


Why is this change here?
It is unrelated to BFT, and I think it is wrong. We check the returned body for the correct response. ListOne is done always from the outside later in the tests.,

tock-ibm · 2023-02-20T10:56:32Z

integration/nwo/configblock.go

+	"github.com/hyperledger/fabric/common/channelconfig"
+	"github.com/hyperledger/fabric/common/policies"
+


tock-ibm · 2023-02-20T10:59:26Z

integration/nwo/template/configtx_template.go

@@ -158,19 +158,16 @@ Profiles:{{ range .Profiles }}
        PreferredMaxBytes: 512 KB
      {{- end}}
      Capabilities:
-        {{- if eq $w.Consensus.Type "BFT" }}


Why indeed?

tock-ibm · 2023-02-20T11:03:02Z

integration/raft/cft_test.go

+				Status:            "active",
 				ConsensusRelation: "consenter",
-				Height:            0,
+				Height:            2,


This is wrong, because Join was changed incorrectly.

tock-ibm · 2023-02-20T11:12:47Z

integration/smartbft/smartbft_test.go

+
+	docker "github.com/fsouza/go-dockerclient"
+	"github.com/hyperledger/fabric-config/configtx"
+	"github.com/hyperledger/fabric-config/configtx/orderer"


tock-ibm · 2023-02-20T11:17:05Z

integration/smartbft/smartbft_test.go

+
+			for _, o := range network.Orderers {
+				By("joining " + o.Name + " to channel as a consenter")
+				channelparticipation.Join(network, o, "testchannel1", genesisBlock, expectedChannelInfoPT)


Join was changed incorrectly. Every usage of Join in the new tests should be revisited.

tock-ibm · 2023-02-20T11:17:34Z

integration/smartbft/smartbft_test.go

+			By("Waiting for followers to see the leader")
+			Eventually(ordererRunners[1].Err(), network.EventuallyTimeout, time.Second).Should(gbytes.Say("Message from 1"))
+			Eventually(ordererRunners[2].Err(), network.EventuallyTimeout, time.Second).Should(gbytes.Say("Message from 1"))
+			Eventually(ordererRunners[3].Err(), network.EventuallyTimeout, time.Second).Should(gbytes.Say("Message from 1"))


how does that prove the existence of a leader?
who guarantees the leader is orderer 0?
see how it is done in Raft IT

tock-ibm · 2023-02-20T11:21:03Z

integration/smartbft/smartbft_test.go

+			By("Waiting for view change to occur")
+			Eventually(ordererRunners[1].Err(), network.EventuallyTimeout*2, time.Second).Should(gbytes.Say("Changing to leader role, current view: 1, current leader: 2 channel=testchannel1"))
+			Eventually(ordererRunners[2].Err(), network.EventuallyTimeout*2, time.Second).Should(gbytes.Say("Changing to follower role, current view: 1, current leader: 2 channel=testchannel1"))
+			Eventually(ordererRunners[3].Err(), network.EventuallyTimeout*2, time.Second).Should(gbytes.Say("Changing to follower role, current view: 1, current leader: 2 channel=testchannel1"))
+			Eventually(ordererRunners[4].Err(), network.EventuallyTimeout*2, time.Second).Should(gbytes.Say("Changing to follower role, current view: 1, current leader: 2 channel=testchannel1"))


again, how can you be sure who the leader will be?

tock-ibm · 2023-02-20T11:24:19Z

integration/smartbft/smartbft_test.go

+		URL:               "/participation/v1/channels/" + channel,
+		Status:            "active",
+		ConsensusRelation: "consenter",
+		Height:            1,


Join was changed incorrectly. Revisit

tock-ibm · 2023-02-21T11:19:02Z

orderer/consensus/smartbft/util.go

+	}
+
+	for _, consenter := range oc.Consenters() {
+		fmt.Println(base64.StdEncoding.EncodeToString(consenter.ServerTlsCert))


leftover from a debug session?

Param-S requested a review from a team as a code owner November 14, 2022 12:17

Param-S marked this pull request as draft November 14, 2022 12:17

Param-S changed the title ~~add SMaRtBFT consensus support~~ WIP: add SMaRtBFT consensus support Nov 14, 2022

Param-S force-pushed the bftchain branch from 2bb9259 to 6ceb688 Compare November 14, 2022 12:22

yacovm reviewed Nov 14, 2022

View reviewed changes

go.sum Outdated Show resolved Hide resolved

Param-S force-pushed the bftchain branch from a591c86 to 238e96d Compare November 16, 2022 09:21

yacovm force-pushed the bftchain branch from 629642a to 978574c Compare November 22, 2022 23:32

Param-S force-pushed the bftchain branch from 2970d56 to 19329b6 Compare December 14, 2022 10:47

andrew-coleman force-pushed the bftchain branch 2 times, most recently from 46f6a1d to d8996a9 Compare January 19, 2023 15:55

Param-S force-pushed the bftchain branch 2 times, most recently from a52e94e to d454ea2 Compare January 23, 2023 13:11

yacovm force-pushed the bftchain branch from 19452da to 7d9938e Compare January 27, 2023 16:35

Param-S mentioned this pull request Jan 31, 2023

test network nano bash updated with smartbft consensus hyperledger/fabric-samples#923

Closed

yacovm reviewed Feb 2, 2023

View reviewed changes

common/policies/bft.go Outdated Show resolved Hide resolved

yacovm reviewed Feb 2, 2023

View reviewed changes

integration/nwo/components.go Outdated Show resolved Hide resolved

yacovm reviewed Feb 2, 2023

View reviewed changes

orderer/common/onboarding/onboarding_test.go Outdated Show resolved Hide resolved

yacovm reviewed Feb 2, 2023

View reviewed changes

orderer/common/server/main.go Outdated Show resolved Hide resolved

yacovm reviewed Feb 2, 2023

View reviewed changes

Param-S force-pushed the bftchain branch 4 times, most recently from 25cdcfd to 4d5a104 Compare February 7, 2023 04:51