CCAAS Builders #3315
Merged
CCAAS Builders #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolves issue #3286 |
jt-nti
previously approved these changes
Mar 31, 2022
mbwhite
force-pushed
the
builder-packaging-redux
branch
2 times, most recently
from
d93f22b
to
edab0fa
Compare
|
/ci-run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mbwhite
force-pushed
the
builder-packaging-redux
branch
4 times, most recently
from
4b9d638
to
2a4bf8e
Compare
|
@denyeart this is good for review :-) |
jt-nti
reviewed
Jul 27, 2022
| @@ -18,5 +18,7 @@ if [ "$(jq -r .type "$META/metadata.json")" == "binary" ]; then | |||
| exit 0 | |||
| fi | |||
|
|
|||
| >&2 cat $META/metadata.json | |||
There was a problem hiding this comment.
well I didn't but then it was useful in debugging - as later on the peer lies about what the language really is.
(i.e. it toUpperCase() the language - so I first assumed the packaging of the contract was wrong
- adjust the makefile to have targets for linux-amd64/darwin-amd64/windows-amd64 - adjust the packaging as suggested in issue 3286 Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
builder-packaging-redux
branch
from
2a4bf8e
to
bddef47
Compare
jt-nti
approved these changes
Jul 28, 2022
denyeart
approved these changes
Jul 29, 2022
|
@Mergifyio backport release-2.5 |
|
@Mergifyio backport release-2.4 |
✅ Backports have been created
|
✅ Backports have been created
|
C0rWin
added a commit
to C0rWin/fabric
that referenced
this pull request
Jul 31, 2022
After hyperledger#3315 was merged, the -buildvcs=false flag was mistakenly removed, this commit fixes the change and adds it back. Signed-off-by: Artem Barger <artem@bargr.net>
yacovm
pushed a commit
that referenced
this pull request
Aug 1, 2022
After #3315 was merged, the -buildvcs=false flag was mistakenly removed, this commit fixes the change and adds it back. Signed-off-by: Artem Barger <artem@bargr.net>
denyeart
pushed a commit
that referenced
this pull request
Aug 1, 2022
denyeart
pushed a commit
that referenced
this pull request
Aug 1, 2022
yacovm
pushed a commit
that referenced
this pull request
Aug 1, 2022
* Add -buildvcs=false for ccaasbuilder After #3315 was merged, the -buildvcs=false flag was mistakenly removed, this commit fixes the change and adds it back. Signed-off-by: Artem Barger <artem@bargr.net> * Enable compilation on linux/arm64 platforms While building the peer docker image the location of the ccaasbuilder binaries was hardcoded into the Dockerfile, though the output directory is platform dependent. Therefore this commit suggest two changes: 1. Prepare binary location based on the architecture and copy them into the temporal location, hence it will become possible to generalize file location inside Dockerfile 2. Suggest static binaries compilation, to include all dependent libraries in compile time, turns out there are different set of libraries between alpine:${ALPINE_VER} and golang:${GO_VER}-alpine${ALPINE_VER} docker images which cause peer to segfault on ARM64 based platforms. Signed-off-by: Artem Barger <artem@bargr.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthew B White whitemat@uk.ibm.com
Type of change
Description
Additional details
Related issues