Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -buildvcs=false for ccaasbuilder #3556

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Add -buildvcs=false for ccaasbuilder #3556

merged 1 commit into from
Aug 1, 2022

Conversation

C0rWin
Copy link
Contributor

@C0rWin C0rWin commented Jul 31, 2022

After #3315 was merged, the -buildvcs=false flag was mistakenly removed. This commit fixes the change and adds it back.

Signed-off-by: Artem Barger artem@bargr.net

@C0rWin
Add -buildvcs=false for ccaasbuilder
04f6233 
After hyperledger#3315 was merged, the -buildvcs=false flag was mistakenly removed,
this commit fixes the change and adds it back.

Signed-off-by: Artem Barger <artem@bargr.net>
@C0rWin C0rWin requested a review from a team as a code owner July 31, 2022 12:49
@C0rWin
Copy link
Contributor Author

C0rWin commented Jul 31, 2022

@mbwhite, can you please take a look?

@mbwhite
Copy link
Member

mbwhite commented Aug 1, 2022

thanks @C0rWin !

I've added my approval to this PR @hyperledger/fabric-core-maintainers could you merge ASAP please..

@yacovm yacovm merged commit dcaf2b2 into hyperledger:main Aug 1, 2022
@mbwhite
Copy link
Member

mbwhite commented Aug 1, 2022

thanks @yacovm

@denyeart
Copy link
Contributor

denyeart commented Aug 1, 2022

@Mergifyio backport release-2.5

@denyeart
Copy link
Contributor

denyeart commented Aug 1, 2022

@Mergifyio backport release-2.4

@mergify mergify bot mentioned this pull request Aug 1, 2022
Merged
@mergify
Copy link

mergify bot commented Aug 1, 2022

backport release-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 1, 2022
@C0rWin @mergify
Add -buildvcs=false for ccaasbuilder (#3556)
8e9132c 
After #3315 was merged, the -buildvcs=false flag was mistakenly removed,
this commit fixes the change and adds it back.

Signed-off-by: Artem Barger <artem@bargr.net>
(cherry picked from commit dcaf2b2)
mergify bot pushed a commit that referenced this pull request Aug 1, 2022
@C0rWin @mergify
Add -buildvcs=false for ccaasbuilder (#3556)
8a9c25a 
After #3315 was merged, the -buildvcs=false flag was mistakenly removed,
this commit fixes the change and adds it back.

Signed-off-by: Artem Barger <artem@bargr.net>
(cherry picked from commit dcaf2b2)
@mergify mergify bot mentioned this pull request Aug 1, 2022
Merged
@mergify
Copy link

mergify bot commented Aug 1, 2022

backport release-2.4

✅ Backports have been created

denyeart pushed a commit that referenced this pull request Aug 1, 2022
@C0rWin @denyeart
Add -buildvcs=false for ccaasbuilder (#3556)
eb6b172 
After #3315 was merged, the -buildvcs=false flag was mistakenly removed,
this commit fixes the change and adds it back.

Signed-off-by: Artem Barger <artem@bargr.net>
(cherry picked from commit dcaf2b2)
denyeart pushed a commit that referenced this pull request Aug 1, 2022
@C0rWin @denyeart
Add -buildvcs=false for ccaasbuilder (#3556)
8d3a18f 
After #3315 was merged, the -buildvcs=false flag was mistakenly removed,
this commit fixes the change and adds it back.

Signed-off-by: Artem Barger <artem@bargr.net>
(cherry picked from commit dcaf2b2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbwhite mbwhite mbwhite approved these changes

@yacovm yacovm yacovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@C0rWin @mbwhite @denyeart @yacovm