Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ubuntu from 20.04 to 22.04 LTS version #4967

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

C0rWin
Copy link
Contributor

@C0rWin C0rWin commented Aug 27, 2024

Moving container images from using Ubuntu 20.04 to Ubuntu 24.04, this is to reduce amount of vulnerabilities reported with 20.04 version, effectively from this

    i New version 1.13.0 available (installed version is 1.11.0) at https://github.com/docker/scout-cli
          ✓ SBOM of image already cached, 218 packages indexed

  Target               │  hyperledger/fabric-peer:latest  │    1C     1H     1M    10L
    digest             │  260a5496cc95                    │
  Base image           │  ubuntu:20.04                    │    0C     0H     1M    10L
  Refreshed base image │  ubuntu:20.04                    │    0C     0H     1M    10L
                       │                                  │
  Updated base image   │  ubuntu:24.04                    │    0C     0H     1M     3L
                       │                                  │                         -7

to this

    i New version 1.13.0 available (installed version is 1.11.0) at https://github.com/docker/scout-cli
          ✓ SBOM of image already cached, 213 packages indexed

    i Base image was auto-detected. To get more accurate results, build images with max-mode provenance attestations.
      Review docs.docker.com ↗ for more information.

  Target             │  hyperledger/fabric-peer:latest  │    0C     0H     1M     3L
    digest           │  bd06340d98f4                    │
  Base image         │  ubuntu:24.04                    │    0C     0H     1M     3L
  Updated base image │  ubuntu:24.10                    │    0C     0H     0M     0L
                     │                                  │                  -1     -3

@C0rWin C0rWin requested a review from a team as a code owner August 27, 2024 19:33
@C0rWin
Copy link
Contributor Author

C0rWin commented Aug 27, 2024

--- FAIL: TestBlockPullerBadBlocks (10.17s)
    --- FAIL: TestBlockPullerBadBlocks/wrong_number (10.02s)
        deliver_test.go:1193: PullBlock did not complete within time
2024-08-27 19:43:17.184 UTC 133f INFO [grpc] Infof -> [transport] [client-transport 0xc00021e248] Closing: connection error: desc = "error reading from server: EOF"

doesn't seem related to my change, re-running UT job again.

@denyeart
Copy link
Contributor

Github is still using 22.04 for ubuntu-latest, and is still calling 24.04 'beta' for some reason - https://github.com/actions/runner-images?tab=readme-ov-file#available-images.
How do you feel about using 22.04 for a more incremental step up?

Not an issue for fabric, but for fabric-ca since it uses CGO updating to a version later than the ultimate server runs causes issues. For this reason I like to keep fabric-ca a little more behind. But I'd be comfortable with 22.04 across all the repositories.

@C0rWin
Copy link
Contributor Author

C0rWin commented Sep 11, 2024

Github is still using 22.04 for ubuntu-latest, and is still calling 24.04 'beta' for some reason - https://github.com/actions/runner-images?tab=readme-ov-file#available-images. How do you feel about using 22.04 for a more incremental step up?

Not an issue for fabric, but for fabric-ca since it uses CGO updating to a version later than the ultimate server runs causes issues. For this reason I like to keep fabric-ca a little more behind. But I'd be comfortable with 22.04 across all the repositories.

I am just fine to use 22.04 also, just feeling more secure to going with the most recent LTS. But I am ok, let's start with 22.04 and then plan switching to 24.04 later on.

Signed-off-by: Artem Barger <artem@bargr.net>
@C0rWin
Copy link
Contributor Author

C0rWin commented Sep 15, 2024

@denyeart, per your suggestion, changed to 22.04.

@denyeart
Copy link
Contributor

Thanks @C0rWin , I think we should also update in each of the github workflows under .github/workflows, right?

@denyeart denyeart changed the title Upgrade ubuntu from 20.04 to 24.04 LTS version Upgrade ubuntu from 20.04 to 22.04 LTS version Sep 16, 2024
@denyeart
Copy link
Contributor

Thanks @C0rWin , I think we should also update in each of the github workflows under .github/workflows, right?

I've done a separate PR - #4986

@C0rWin
Copy link
Contributor Author

C0rWin commented Sep 17, 2024

Thanks @C0rWin , I think we should also update in each of the github workflows under .github/workflows, right?

yeap

@ryjones
Copy link
Member

ryjones commented Sep 17, 2024

@C0rWin I can also move -latest to 24.04, let me know

@denyeart
Copy link
Contributor

Talked to Ry, we're just going to use fabric-ubuntu-22.04 for the time being.

@denyeart denyeart merged commit ae7cb6f into hyperledger:main Sep 17, 2024
12 of 15 checks passed
@denyeart
Copy link
Contributor

In the Makefile 22.04 is correct, merged.

@C0rWin C0rWin deleted the ubuntu-update branch September 19, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants