-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Go to 1.23.1 #4974
Bump Go to 1.23.1 #4974
Conversation
Bump Go to 1.23.1. Also update go.mod to use three digit version to indicate toolchain version (most Go projects have switched to this approach at this point). Signed-off-by: David Enyeart <enyeart@us.ibm.com>
@@ -1,6 +1,6 @@ | |||
module github.com/hyperledger/fabric | |||
|
|||
go 1.23 | |||
go 1.23.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't it work to keep the 2-digit version? 1.23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't it work to keep the 2-digit version? 1.23
It did work with the 2-digit version. However all the Go documentation says to use a 3-digit version for the toolchain. Since we don't have a different toolchain version listed, it will use the Go directive version instead. Therefore to be aligned with the documentation it is better to switch to the 3-digit version so that nothing unexpected happens. I realize I was reluctant to make this move earlier, but most of the Go community is moving to this approach and I'm now on board.
@satota2 Note that broken link checker is expected to fail as there are still some old doc issues. It only runs when the job file is updated, and is not a required check for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@denyeart
Thanks for letting me know. I'll go ahead and ignore the failure and proceed with the merge.
Bump Go to 1.23.1.
Also update go.mod to use three digit version to indicate toolchain version (most Go projects have switched to this approach at this point).