Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go to 1.23.1 #4974

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Bump Go to 1.23.1 #4974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/broken-link-checker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
- .github/workflows/broken-link-checker.yml

env:
GO_VER: 1.23.0
GO_VER: 1.23.1

permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
- v3.*

env:
GO_VER: 1.23.0
GO_VER: 1.23.1
UBUNTU_VER: 20.04
FABRIC_VER: ${{ github.ref_name }}
DOCKER_REGISTRY: ${{ github.repository_owner == 'hyperledger' && 'docker.io' || 'ghcr.io' }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/verify-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
env:
GOPATH: /opt/go
PATH: /opt/go/bin:/bin:/usr/bin:/sbin:/usr/sbin:/usr/local/bin:/usr/local/sbin
GO_VER: 1.23.0
GO_VER: 1.23.1

permissions:
contents: read # to fetch code (actions/checkout)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vulnerability-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.23.0
go-version: 1.23.1
- name: Scan
run: make scan
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ METADATA_VAR += CommitSHA=$(EXTRA_VERSION)
METADATA_VAR += BaseDockerLabel=$(BASE_DOCKER_LABEL)
METADATA_VAR += DockerNamespace=$(DOCKER_NS)

GO_VER = 1.23.0
GO_VER = 1.23.1
GO_TAGS ?=

RELEASE_EXES = orderer $(TOOLS_EXES)
Expand Down
4 changes: 2 additions & 2 deletions docs/source/prereqs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ Optional: Install the latest Fabric supported version of [Go](https://golang.org
installed (only required if you will be writing Go chaincode or SDK applications).

```shell
brew install go@1.23.0
go version # => go1.23.0 darwin/amd64
brew install go@1.23.1
go version # => go1.23.1 darwin/amd64
```

### JQ
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/hyperledger/fabric

go 1.23
go 1.23.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't it work to keep the 2-digit version? 1.23

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't it work to keep the 2-digit version? 1.23

It did work with the 2-digit version. However all the Go documentation says to use a 3-digit version for the toolchain. Since we don't have a different toolchain version listed, it will use the Go directive version instead. Therefore to be aligned with the documentation it is better to switch to the 3-digit version so that nothing unexpected happens. I realize I was reluctant to make this move earlier, but most of the Go community is moving to this approach and I'm now on board.


require (
code.cloudfoundry.org/clock v1.0.0
Expand Down
2 changes: 1 addition & 1 deletion tools/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module tools

go 1.22
go 1.23.1

require (
github.com/AlekSi/gocov-xml v0.0.0-20190121064608-3a14fb1c4737
Expand Down
2 changes: 1 addition & 1 deletion vagrant/golang.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# SPDX-License-Identifier: Apache-2.0

GOROOT='/opt/go'
GO_VERSION=1.23.0
GO_VERSION=1.23.1

# ----------------------------------------------------------------
# Install Golang
Expand Down
Loading