Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1852 - comma not recognized as a separator character #1913

Merged
merged 5 commits into from
Jun 4, 2022

Conversation

BePo65
Copy link
Contributor

@BePo65 BePo65 commented May 27, 2022

The comma is a very common word separator used in dates with short or long month names (see issue #1852); so it should be part of the characters, recognized as word separators.

When fixing this issue, I noticed that the characters used as word separators in 'formattingTokens' (split format string into tokens) and 'matchWord' (find separators between date parts) differ: the underscore was missing in 'formattingTokens' - fixed that too.

iamkun and others added 5 commits May 7, 2022 00:15
## [1.11.2](iamkun/dayjs@v1.11.1...v1.11.2) (2022-05-06)

### Bug Fixes

* add OpUnitType (week) to quarterOfYear startOf/endOf types ([iamkun#1865](iamkun#1865)) ([400bc3e](iamkun@400bc3e))
* Fix type issue with ManipulateType ([iamkun#1864](iamkun#1864)) ([d033dfc](iamkun@d033dfc))
* fix UTC plugin .valueOf not taking DST into account  ([iamkun#1448](iamkun#1448)) ([27d1c50](iamkun@27d1c50))
Dash could be misinterpreted as range operator.
In 'formatTokens' dash is not recognized as a word separator, but in
'matchWord' it is.
@iamkun
Copy link
Owner

iamkun commented Jun 4, 2022

Thanks.

We should comma as a separator

@iamkun iamkun merged commit 41b1405 into iamkun:dev Jun 4, 2022
@BePo65 BePo65 deleted the fix/issue1852 branch June 4, 2022 15:49
iamkun pushed a commit that referenced this pull request Jun 6, 2022
## [1.11.3](v1.11.2...v1.11.3) (2022-06-06)

### Bug Fixes

*  customParseFormat plugin to parse comma as a separator character ([#1913](#1913)) ([41b1405](41b1405))
* update Dutch [nl] locale ordinal ([#1908](#1908)) ([5da98f8](5da98f8))
@iamkun
Copy link
Owner

iamkun commented Jun 6, 2022

🎉 This PR is included in version 1.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Jun 6, 2022
iamkun pushed a commit that referenced this pull request Jun 11, 2022
## [1.11.3](v1.11.2...v1.11.3) (2022-06-06)

### Bug Fixes

*  customParseFormat plugin to parse comma as a separator character ([#1913](#1913)) ([41b1405](41b1405))
* update Dutch [nl] locale ordinal ([#1908](#1908)) ([5da98f8](5da98f8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants