Skip to content

Commit

Permalink
[SYCL][E2E][Bindless] Fix -Werror issues (#14912)
Browse files Browse the repository at this point in the history
Consists of two parts:
1. Fix the setting of `-Werror` on Windows in general for E2E tests
* Just appending to `SYCL_E2E_CLANG_CXX_FLAGS` adds an extra semicolon
that causes the command line to fail
3. Address remaining `-Werror` failures in Bindless Images E2E tests
    * Add return from function, even though there's an `assert(false)`
  • Loading branch information
ProGTX authored Aug 5, 2024
1 parent 232c95c commit c455b6f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion sycl/test-e2e/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ if(MSVC AND NOT SYCL_TEST_E2E_STANDALONE)
else()
set(SYCL_E2E_CLANG_CXX_FLAGS ${CMAKE_CXX_FLAGS})
endif()
list(APPEND SYCL_E2E_CLANG_CXX_FLAGS "-Werror")

set(SYCL_E2E_CLANG_CXX_FLAGS "${SYCL_E2E_CLANG_CXX_FLAGS} -Werror")

if(SYCL_TEST_E2E_STANDALONE)
configure_file("${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in"
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/bindless_images/helpers/sampling.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -662,6 +662,7 @@ read(sycl::range<2> globalSize, sycl::vec<float, 2> coords, float offset,
}
}
assert(false && "Invalid sampler encountered!");
return {};
}

}; // namespace sampling_helpers

0 comments on commit c455b6f

Please sign in to comment.