[SYCL][E2E][Bindless] Fix -Werror issues #14912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacault
approved these changes
Aug 2, 2024
DBDuncan
approved these changes
Aug 2, 2024
uditagarwal97
approved these changes
Aug 2, 2024
|
Only test failure seems to be a general failure with the HIP runner, not related to this patch: https://github.com/intel/llvm/actions/runs/10212256670/job/28255418130?pr=14912 Besides that this seems ready to merge @intel/llvm-gatekeepers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consists of two parts:
-Werroron Windows in general for E2E testsSYCL_E2E_CLANG_CXX_FLAGSadds an extra semicolon that causes the command line to fail-Werrorfailures in Bindless Images E2E testsassert(false)