[SYCL] Fix abs_diff host implementation #12859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In intel#12856 I misunderstood what the spec meant by > When the inputs are scalars, returns |x - y|. Otherwise, returns > |x[i]- y[i]| for each element of x and y. The subtraction is done > without modulo overflow. The behavior is undefined if the result > cannot be represented by the return type. Fix it here. We still differ from non-preview mode in return type - it used to be `unsigned` prior to SYCL2020 revision 8, I believe.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #12856 I misunderstood what the spec meant by
Fix it here. We still differ from non-preview mode in return type - it used to be
unsignedprior to SYCL2020 revision 8, I believe.