Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Fix abs_diff host implementation #12859

Merged
merged 1 commit into from
Feb 29, 2024

Commits on Feb 28, 2024

  1. [SYCL] Fix abs_diff host implementation

    In intel#12856 I misunderstood what the
    spec meant by
    
    > When the inputs are scalars, returns |x - y|. Otherwise, returns
    > |x[i]- y[i]| for each element of x and y. The subtraction is done
    > without modulo overflow. The behavior is undefined if the result
    > cannot be represented by the return type.
    
    Fix it here. We still differ from non-preview mode in return type - it
    used to be `unsigned` prior to SYCL2020 revision 8, I believe.
    aelovikov-intel committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c2f0951 View commit details
    Browse the repository at this point in the history