Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow notebook==6.* since it seems to work for me. #321

Merged
merged 2 commits into from
Aug 5, 2019
Merged

Allow notebook==6.* since it seems to work for me. #321

merged 2 commits into from
Aug 5, 2019

Conversation

juliusvonkohout
Copy link
Contributor

No description provided.

lresende
lresende approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should squash with better title :)

@lresende
Copy link
Member

lresende commented Aug 2, 2019

But we should also have a clean build before we merge it

@kevin-bates kevin-bates mentioned this pull request Aug 2, 2019
Merged
@lresende lresende merged commit ae4a463 into jupyter-server:master Aug 5, 2019
@juliusvonkohout
Copy link
Contributor Author

Thanks @lresende . Will there be a new pypi release?

@juliusvonkohout juliusvonkohout mentioned this pull request Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lresende lresende lresende approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusvonkohout @lresende