Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handler to be more compatible with tornado/pyzmq updates #322

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

kevin-bates
Copy link
Member

This addresses build issues related to allowing Notebook 6 support (#321). However, I'm suspicious of jupyter_client 5.3.1 which may be causing this issue near the end of the tests...

Exception in thread Thread-31:
Traceback (most recent call last):
  File "/opt/anaconda3/envs/kernel-gateway-dev/lib/python3.6/threading.py", line 916, in _bootstrap_inner
  File "/opt/anaconda3/envs/kernel-gateway-dev/lib/python3.6/site-packages/jupyter_client/channels.py", line 167, in run
  File "/opt/anaconda3/envs/kernel-gateway-dev/lib/python3.6/site-packages/jupyter_client/channels.py", line 94, in _create_socket
  File "/opt/anaconda3/envs/kernel-gateway-dev/lib/python3.6/site-packages/zmq/sugar/context.py", line 146, in socket
  File "/opt/anaconda3/envs/kernel-gateway-dev/lib/python3.6/site-packages/zmq/sugar/socket.py", line 59, in __init__
  File "zmq/backend/cython/socket.pyx", line 328, in zmq.backend.cython.socket.Socket.__init__
zmq.error.ZMQError: Too many open files

We should revisit this issue once this PR is merged and we can see how PR #321 behaves.

@lresende lresende merged commit 349b5ae into jupyter-server:master Aug 2, 2019
@kevin-bates kevin-bates deleted the fix-base-spec-handler branch September 19, 2019 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants