Allow enabling sarama logging and disabling client pool

[pierDipi]

Add 3 new environment variables:

ENABLE_SARAMA_LOGGER       (default: false)
ENABLE_SARAMA_DEBUG_LOGGER (default: false)
ENABLE_SARAMA_CLIENT_POOL  (default: true)

I want to see if these help with giving more information to debug this issue: #4091

[pierDipi]

/cherry-pick release-1.15

[knative-prow-robot]

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pierDipi]

/cherry-pick release-1.14

[knative-prow-robot]

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 44.15584% with 43 lines in your changes missing coverage. Please review.

Project coverage is 48.43%. Comparing base (8b4b0dd) to head (88d3021).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
control-plane/pkg/kafka/clientpool/clientpool.go	21.42%	11 Missing ⚠️
control-plane/cmd/kafka-controller/main.go	0.00%	6 Missing ⚠️
...ane/pkg/reconciler/broker/namespaced_controller.go	0.00%	5 Missing ⚠️
...l-plane/pkg/reconciler/consumergroup/controller.go	42.85%	2 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/trigger/controller.go	42.85%	2 Missing and 2 partials ⚠️
...ne/pkg/reconciler/trigger/namespaced_controller.go	42.85%	2 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/broker/controller.go	70.00%	1 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/channel/controller.go	76.92%	1 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/sink/controller.go	62.50%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4103      +/-   ##
==========================================
- Coverage   48.55%   48.43%   -0.12%     
==========================================
  Files         244      244              
  Lines       14827    14870      +43     
==========================================
+ Hits         7199     7203       +4     
- Misses       6913     6940      +27     
- Partials      715      727      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matzew]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matzew,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[creydr]

/lgtm

[knative-prow-robot]

@pierDipi: #4103 failed to apply on top of branch "release-1.15":

Applying: Allow enabling sarama logging and disabling client pool
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/broker/controller.go
M	control-plane/pkg/reconciler/broker/namespaced_controller.go
M	control-plane/pkg/reconciler/channel/controller.go
M	control-plane/pkg/reconciler/consumergroup/controller.go
M	control-plane/pkg/reconciler/sink/controller.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane/pkg/reconciler/sink/controller.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/sink/controller.go
Auto-merging control-plane/pkg/reconciler/consumergroup/controller.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/consumergroup/controller.go
Auto-merging control-plane/pkg/reconciler/channel/controller.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/channel/controller.go
Auto-merging control-plane/pkg/reconciler/broker/namespaced_controller.go
Auto-merging control-plane/pkg/reconciler/broker/controller.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/broker/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow enabling sarama logging and disabling client pool
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow-robot]

@pierDipi: #4103 failed to apply on top of branch "release-1.14":

Applying: Allow enabling sarama logging and disabling client pool
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/broker/controller.go
M	control-plane/pkg/reconciler/broker/namespaced_controller.go
M	control-plane/pkg/reconciler/channel/controller.go
M	control-plane/pkg/reconciler/consumergroup/controller.go
M	control-plane/pkg/reconciler/sink/controller.go
M	control-plane/pkg/reconciler/trigger/controller.go
M	control-plane/pkg/reconciler/trigger/namespaced_controller.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane/pkg/reconciler/trigger/namespaced_controller.go
Auto-merging control-plane/pkg/reconciler/trigger/controller.go
Auto-merging control-plane/pkg/reconciler/sink/controller.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/sink/controller.go
Auto-merging control-plane/pkg/reconciler/consumergroup/controller.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/consumergroup/controller.go
Auto-merging control-plane/pkg/reconciler/channel/controller.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/channel/controller.go
Auto-merging control-plane/pkg/reconciler/broker/namespaced_controller.go
Auto-merging control-plane/pkg/reconciler/broker/controller.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/broker/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow enabling sarama logging and disabling client pool
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.