-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.15] Allow enabling sarama logging and disabling client pool (#4103) #4108
[release-1.15] Allow enabling sarama logging and disabling client pool (#4103) #4108
Conversation
…nsions#4103) Add 3 new environment variables: ``` ENABLE_SARAMA_LOGGER (default: false) ENABLE_SARAMA_DEBUG_LOGGER (default: false) ENABLE_SARAMA_CLIENT_POOL (default: true) ``` Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test reconciler-tests |
/retest-required |
/test upgrade-tests |
f62e51f
into
knative-extensions:release-1.15
…nsions#4103) (knative-extensions#4108) Add 3 new environment variables: ``` ENABLE_SARAMA_LOGGER (default: false) ENABLE_SARAMA_DEBUG_LOGGER (default: false) ENABLE_SARAMA_CLIENT_POOL (default: true) ``` Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…ol and Upgrade knative.dev/eventing to latest 1.15 (#1278) * Allow enabling sarama logging and disabling client pool (knative-extensions#4103) (knative-extensions#4108) Add 3 new environment variables: ``` ENABLE_SARAMA_LOGGER (default: false) ENABLE_SARAMA_DEBUG_LOGGER (default: false) ENABLE_SARAMA_CLIENT_POOL (default: true) ``` Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Upgrade knative.dev/eventing to latest 1.15 (knative-extensions#4112) * Upgrade knative.dev/eventing to latest 1.15 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Pass PodLister as expected Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Migrate to library SchedulerFunc to use the new signature Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Backport of #4103