-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plain JSON body in func invoke with HTTP #1039
Conversation
/lgtm |
I see how could I cause test breakage, but I don't see how could I have cause race. |
I think the race must have been there all along and it only manifest when assert fails. |
2a9fa8a
to
06b96e4
Compare
Another weird thing |
Codecov Report
@@ Coverage Diff @@
## main #1039 +/- ##
=======================================
Coverage 46.70% 46.70%
=======================================
Files 59 59
Lines 7730 7736 +6
=======================================
+ Hits 3610 3613 +3
- Misses 3775 3777 +2
- Partials 345 346 +1
Continue to review full report at Codecov.
|
06b96e4
to
fc0e482
Compare
@lance PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
But we should address the race condition
Do not use form encoding. Signed-off-by: Matej Vasek <mvasek@redhat.com>
fc0e482
to
472ea95
Compare
@lance ok I fixed potential race, plz final lgtm |
CI is flaking more than usual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this as well 👍🏻
I am perplexed why the tests would throw a race error now and not earlier, however.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
You cannot call |
/unhold |
Changes
Using plain JSON body in func invoke with HTTP instead of form encoding.
Fixes: #1038