Plain JSON body in func invoke with HTTP

[matejvasek]

Changes

Using plain JSON body in func invoke with HTTP instead of form encoding.

Fixes: #1038

Changes the invoke command for HTTP functions to use standard HTTP POST with JSON instead of multi-part form encoding

[lance]

/lgtm
However
/hold for test fixes

[matejvasek]

I see how could I cause test breakage, but I don't see how could I have cause race.

[matejvasek]

I see how could I cause test breakage, but I don't see how could I have cause race.

I think the race must have been there all along and it only manifest when assert fails.

[matejvasek]

Another weird thing var invoked bool is being writen and read from different goroutines but race is not reported, what the hell.

[codecov]

Codecov Report

Merging #1039 (472ea95) into main (5e26510) will increase coverage by 0.00%.
The diff coverage is 57.14%.

@@           Coverage Diff           @@
##             main    #1039   +/-   ##
=======================================
  Coverage   46.70%   46.70%           
=======================================
  Files          59       59           
  Lines        7730     7736    +6     
=======================================
+ Hits         3610     3613    +3     
- Misses       3775     3777    +2     
- Partials      345      346    +1     

Impacted Files	Coverage Δ
invoke.go	47.82% <57.14%> (+0.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e26510...472ea95. Read the comment docs.

[matejvasek]

@lance PTAL

[lance]

/lgtm
But we should address the race condition

[matejvasek]

@lance ok I fixed potential race, plz final lgtm

[matejvasek]

CI is flaking more than usual.

[lkingland]

I prefer this as well 👍🏻

I am perplexed why the tests would throw a race error now and not earlier, however.

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matejvasek]

@lkingland

I am perplexed why the tests would throw a race error now and not earlier, however.

You cannot call t.Fatal() outside the main test goroutine (t.Error() seems to be ok).

[matejvasek]

/unhold