Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add target="_blank" to Markdown links in NodeDescription and ChatMessage components #4060

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request adds the target="_blank" attribute to Markdown links in the NodeDescription and ChatMessage components. This allows the links to open in a new tab when clicked.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 7, 2024
@dosubot dosubot bot added the enhancement New feature or request label Oct 7, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Oct 7, 2024
Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 7, 2024
@@ -207,7 +207,7 @@ export default function ChatMessage({
/>
) : (
<Markdown
remarkPlugins={[remarkGfm]}
linkTarget="_blank"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove Gfm?

@anovazzi1 anovazzi1 enabled auto-merge (squash) October 8, 2024 14:05
@anovazzi1 anovazzi1 merged commit 94a647f into main Oct 8, 2024
19 checks passed
@anovazzi1 anovazzi1 deleted the targetBlankMd branch October 8, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants