Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add target="_blank" to Markdown links in NodeDescription and ChatMessage components #4060

Merged
merged 2 commits into from
Oct 8, 2024
+2 −0
Merged

feat: Add target="_blank" to Markdown links in NodeDescription and ChatMessage components #4060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fc025a
feat: Add target="_blank" to Markdown links in NodeDescription and Ch…
anovazzi1 Oct 7, 2024
7d44b9b
added gfm back
anovazzi1 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/frontend/src/CustomNodes/GenericNode/components/NodeDescription/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ export default function NodeDescription({
emptyPlaceholder
) : (
<Markdown
linkTarget="_blank"
className={cn(
"markdown prose flex h-full w-full flex-col text-primary word-break-break-word note-node-markdown dark:prose-invert",
mdClassName,
Expand Down
1 change: 1 addition & 0 deletions src/frontend/src/modals/IOModal/components/chatView/chatMessage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ export default function ChatMessage({
) : (
<Markdown
remarkPlugins={[remarkGfm]}
linkTarget="_blank"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove Gfm?

rehypePlugins={[rehypeMathjax]}
className={cn(
"markdown prose flex flex-col word-break-break-word dark:prose-invert",
Expand Down