Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Integrate telemetry action #984

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

uncleDecart
Copy link
Collaborator

This action will gather statistics around eden test execution in GitHub Runners, helping us identify bottlenecks

CC: @milan-zededa

Let's see what we have in Eden repo

Copy link
Contributor

@milan-zededa milan-zededa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works well we could keep this beyond the current issue troubleshooting.

@uncleDecart
Copy link
Collaborator Author

If this works well we could keep this beyond the current issue troubleshooting.

Yep, I hope it works during failure as well, they should give some outputs :D

@milan-zededa
Copy link
Contributor

milan-zededa commented Jun 18, 2024

I see error Error: [Workflow Telemetry] Resource not accessible by integration, although diagrams are provided...

@uncleDecart
Copy link
Collaborator Author

image image

Huh, CPU load goes in the beginning high, we are not using much resources

@uncleDecart
Copy link
Collaborator Author

Seems to be working, adding sys calls information to get better visibility.

@giggsoff
Copy link
Collaborator

Seems to be working, adding sys calls information to get better visibility.

Can you please check Step Trace section? Looks like it contains only one (or two) steps. Are you sure that other charts contains the whole workflow?

@uncleDecart
Copy link
Collaborator Author

you're absolutely right @giggsoff, let's try this one :D

@uncleDecart
Copy link
Collaborator Author

Seems like it works time wise, still this steps are weirdly seen, could be because of reusable actions?

@giggsoff
Copy link
Collaborator

Seems like it works time wise, still this steps are weirdly seen, could be because of reusable actions?

I can see related issue here.

@uncleDecart
Copy link
Collaborator Author

So am I being punished for over-engineering separating things? Oh man. Well, we can create an action without this hierarchy, but still biggest question is how can we see nested virtualisation impact? It should be something like count of context change, but for that we technically need to get to host, from guest machine maybe sleep time could help?

@milan-zededa
Copy link
Contributor

So am I being punished for over-engineering separating things? Oh man. Well, we can create an action without this hierarchy, but still biggest question is how can we see nested virtualisation impact? It should be something like count of context change, but for that we technically need to get to host, from guest machine maybe sleep time could help?

Maybe this could be relevant for us: https://scoutapm.com/blog/understanding-cpu-steal-time-when-should-you-be-worried

This action will gather statistics around eden test execution in GitHub
Runners, helping us identify bottlenecks

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
@uncleDecart
Copy link
Collaborator Author

@milan-zededa I think we should merge this and then in my separate fork I'll run this on self-hosted runner so that we can compare numbers and talk to buildjet about it

@milan-zededa milan-zededa merged commit 756b550 into lf-edge:master Jun 21, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants