Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add in ktlintCheck to daily cron job #284

Merged
merged 4 commits into from
Nov 28, 2022
Merged

ci: Add in ktlintCheck to daily cron job #284

merged 4 commits into from
Nov 28, 2022

Conversation

mchuangatmp
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Add in ktlintCheck to daily cron job
  • Add in a few dependabot passing changes

Testing Plan

  • Regression tests should pass

Reference Issue

@mchuangatmp mchuangatmp changed the title ci: Add in ktlinCheck to daily cron job ci: Add in ktlintCheck to daily cron job Nov 26, 2022
markvdouw
markvdouw approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@markvdouw markvdouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchuangatmp mchuangatmp merged commit 1d23a5f into development Nov 28, 2022
@mchuangatmp mchuangatmp deleted the ci/SQDSDKS-4870 branch November 28, 2022 21:24
mparticle-automation added a commit that referenced this pull request Dec 2, 2022
@mparticle-automation
chore: 5.48.3 (release)
fbb2f16 
## [5.48.3](v5.48.2...v5.48.3) (2022-12-02)

### Bug Fixes

* Error handle null user attribute better and add use case to test file ([#290](#290)) ([8412478](8412478))
* Error handle null user attribute value ([#288](#288)) ([73872df](73872df))

### Updates & Maintenance

* Add in ktlintCheck to daily cron job ([#284](#284)) ([1d23a5f](1d23a5f))
* Update submodules ([375b0d3](375b0d3))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.48.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markvdouw markvdouw markvdouw approved these changes

@einsteinx2 einsteinx2 Awaiting requested review from einsteinx2

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchuangatmp @mparticle-automation @markvdouw